[#VWR-4070] OpenJPEG: LLImageJ2COJ::decodeImpl does not check if requested channel is higher than available

1. Second Life Viewer - VWR

OpenJPEG: LLImageJ2COJ::decodeImpl does not check if requested channel is higher than available

Created: 30/Dec/07 04:35 PM Updated: 14/Mar/09 08:36 PM

Return to search

Component/s:

Source Code

Affects Version/s:

Source code

Fix Version/s:

1.22

File Attachments:

openjpeg_check_number_of_components.diff (0.7 kB)
2.

openjpeg_check_number_of_components_1.20.diff (0.7 kB)

Environment:

Linux Kubuntu Feisty x86_64

Issue Links:

Relates

This issue Relates to:

VWR-2342 Meta-Issue: OpenJPEG bugs

Last Triaged:	19/Jun/08 04:30 PM
Linden Lab Issue ID:	DEV-10215
Patch attached:	Patch attached
Linden Lab Internal Branch:	maint-viewer-9

Description

« Hide

I have encountered a rare error condition (seems not to happen on all sims) where the OPENJPEG LLImageJ2COJ::decodeImpl method is called with the first_channel being higher than the number of channels (image->numcomps) in the J2K image (parsed from the header).

I have not verified what textures produce this but as far as I see from the sources this has something to do with masks for baked textures.

With the current viewer this leads to a crash because the number of components for the image size is calculated as 0 in this case so the size will become 0,
too. The error message will look like this: "LLImageBase::allocateData called with bad dimentions: 16x16x0"

I have attached a patch which catches this and simply flags the decoding as having failed.

All

Comments

Change History

Sort Order:

Soft Linden made changes - 07/Feb/08 02:35 PM

Field	Original Value	New Value
Assignee		Soft Linden [ Soft Linden ]

lindenrobot made changes - 07/Feb/08 02:36 PM

Linden Lab Issue ID

DEV-10215

Rob Linden made changes - 08/Feb/08 11:19 AM

Patch attached

[Patch attached]

Carjay McGinnis made changes - 24/Apr/08 03:07 PM

Attachment

openjpeg_check_number_of_components_1.20.diff [ 16369 ]

Michelle2 Zenovka made changes - 15/May/08 01:32 AM

Link

This issue Relates to VWR-2342 [ VWR-2342 ]

Rob Linden made changes - 19/Jun/08 04:30 PM

Last Triaged

19/Jun/08 04:30 PM

Soft Linden made changes - 07/Aug/08 12:24 PM

Status	Open [ 1 ]	Fix Pending [ 10001 ]
Linden Lab Internal Branch		maint-viewer-9

Sue Linden made changes - 13/Nov/08 11:08 AM

Workflow

jira-2007-12-22a [ 50909 ]

jira-2008-11-14 [ 64614 ]

Sue Linden made changes - 13/Nov/08 11:29 AM

Workflow

jira-2007-12-22a [ 64614 ]

jira-2008-11-14 [ 72450 ]

Sue Linden made changes - 13/Nov/08 04:59 PM

Workflow

jira-2008-11-14 [ 72450 ]

jira-2008-11-14a [ 97064 ]

Sue Linden made changes - 13/Nov/08 05:14 PM

Workflow

jira-2008-11-14 [ 97064 ]

jira-2008-11-14a [ 102509 ]

Sue Linden made changes - 13/Nov/08 05:24 PM

Workflow

jira-2008-11-14 [ 102509 ]

jira-2008-11-14a [ 106038 ]

Sue Linden made changes - 13/Nov/08 05:37 PM

Workflow

jira-2008-11-14 [ 106038 ]

jira-2008-11-14a [ 111243 ]

Sue Linden made changes - 13/Nov/08 06:07 PM

Workflow

jira-2008-11-14 [ 111243 ]

jira-2008-11-14a [ 121689 ]

Sue Linden made changes - 13/Nov/08 06:34 PM

Workflow

jira-2008-11-14 [ 121689 ]

jira-2008-11-14a [ 131543 ]

Sue Linden made changes - 13/Nov/08 06:53 PM

Workflow

jira-2008-11-14 [ 131543 ]

jira-2008-11-14a [ 138798 ]

Soft Linden made changes - 15/Jan/09 01:52 PM

Status	Fix Pending [ 10001 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Dessie Linden made changes - 13/Mar/09 08:27 AM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Fix Pending [ 10001 ]

Dessie Linden made changes - 13/Mar/09 08:27 AM

Fix Version/s

1.22 [ 10430 ]

Dessie Linden made changes - 14/Mar/09 08:36 PM

Status	Fix Pending [ 10001 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]