• All submissions to this site are governed by Second Life Project Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.
MAINTENANCE ANNOUNCEMENT - JIRA will undergo maintenance starting 1:00am PDT through 3:00am on Saturday 2010.03.20. Please do not enter issues during this time as the system maybe restarted.
Issue Details (XML | Word | Printable)

Key: VWR-4057
Type: Bug Bug
Status: Fix Pending Fix Pending
Priority: Critical Critical
Assignee: Soft Linden
Reporter: Domchi Underwood
Votes: 4
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
1. Second Life Viewer - VWR

Multi-line chat display bug - first character in line missing

Created: 29/Dec/07 06:54 PM   Updated: 09/Jun/09 05:08 PM
Component/s: Chat/IM, Scripting, User Interface
Affects Version/s: 1.20, 1.18.5.3, 1.19.0 Release Candidate, 1.21, 1.22, 1.23 Release Candidate
Fix Version/s: 1.20 Release Candidate

Time Tracking:
Not Specified

File Attachments: 1. Text File 20071230.patch (0.5 kB)
2. Text File VWR-4057-linden.patch (2 kB)

Image Attachments:

1. Chat_bug.jpg
(145 kB)
Issue Links:
Relates
 

Last Triaged: 12/Mar/09 01:07 PM
Source Version: 1.18.5.3
Linden Lab Issue ID: DEV-8536
Patch attached: Patch attached
Linden Lab Internal Branch: maint-viewer-14


 Description  « Hide
In all clients (official and Windlight), when script says something with \n the first character in line is missing. This happens only on console, but not in chat window. Also, if there is no hard return (newline), chat gets wrapped correctly.

Reproduction:
default
{
touch_start(integer total_number)

{ llSay(0, "One morning, when Gregor Samsa woke from troubled dreams, he found himself transformed in his bed into a horrible vermin. He lay on his armour-like back, and if he lifted his head a little he could see his brown belly, slightly domed and divided by arches into stiff sections. The bedding was hardly able to cover it and seemed ready to slide off any moment.\nHis many legs, pitifully thin compared with the size of the rest of him, waved about helplessly as he looked."); }

}

Compare with this, which wraps correctly:
default
{
touch_start(integer total_number)

{ llSay(0, "One morning, when Gregor Samsa woke from troubled dreams, he found himself transformed in his bed into a horrible vermin. He lay on his armour-like back, and if he lifted his head a little he could see his brown belly, slightly domed and divided by arches into stiff sections. The bedding was hardly able to cover it and seemed ready to slide off any moment. [no hard return] His many legs, pitifully thin compared with the size of the rest of him, waved about helplessly as he looked."); }

}

Screenshot attached.



 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Alissa Sabre added a comment - 29/Dec/07 07:57 PM
The is an additional explanation of the screenshot. (I took nearly 20 minutes to find it...)

The screenshot contains two similar texts from an object. The first one is from the second script (with "[no hard return]" removed), and the second one is from the first script. The problem is on the sixth line (i.e., the third line in the second texts.) The left most part of the line starts with "ny moment" although it should be "any moment". An "a" is missing.

Domchi, please correct me if I'm wrong.


Alissa Sabre added a comment - 29/Dec/07 08:11 PM
I added 1.18.5.3 to "Affects Versions" because I tested this issue with 1.18.5.3 and it reproduced. It is always better to mark at least one version when reporting a bug.

I have not yet tested on other versions.


Domchi Underwood added a comment - 29/Dec/07 09:19 PM
Yes, you're correct. Sorry if my description wasn't clear enough.

Not only missing "a" at the start of line 6, but also missing "l" at the start of line 5. Basically, the first letter in each wrapped line gets eaten. The lines which are not wrapped (don't have "\n" before them) display OK (see the last line in example).


Alissa Sabre added a comment - 29/Dec/07 10:42 PM
Thank you Domchi for clarification. I didn't noticed the missing l at the fifth line...

I tested this issue on 1.18.6.3 RC viewer and verified that it persists on the versioin. I added "1.18.6 RC" on "affects versions" to reflect it.


Alissa Sabre added a comment - 30/Dec/07 12:02 AM
I believe I located the cause of this bug. I produced a patch (20071230.patch) against 1.18.5.3 source. I believe it works with 1.18.6.3 source (although I may be wrong since I have never seen the 1.18.6.3 source...)

Domchi Underwood added a comment - 30/Dec/07 12:21 AM
Wow this was quick, 5 hours from submitting to the patch, together with one round of feedback. Can I nominate Alissa for "fastest patcher ever" somewhere?

Alissa, thanks.


Alissa Sabre added a comment - 12/Jan/08 10:42 PM
This issue persists in the viewer build from 1.19.0 Beta (76838) source.

I also put a box with a test script on http://slurl.com/secondlife/Hippotropolis/158/211/27 so that anybody can test this issue easily...


Tofu Linden added a comment - 11/Feb/08 12:44 PM
Thanks.
Here's an alternative fix - it gets rid of the skip_chars nonsense which was fundamentally broken with line-wrapping.

Tofu Linden added a comment - 12/Feb/08 07:59 AM
Thanks for the report and patch, including the Kafka repro.

Domchi Underwood added a comment - 12/Apr/08 08:28 PM
This fix still didn't make it to the viewer. Anyone know why?

Tofu Linden added a comment - 14/Apr/08 03:45 AM
Yes, it's part of a maintenance branch that still hasn't gone through QA yet.

Domchi Underwood added a comment - 14/Apr/08 03:49 AM
Thanks Tofu, good to know.

Gellan Glenelg added a comment - 21/May/08 06:57 PM
Fixed in 1.20.7 (87883)

Thickbrick Sleaford added a comment - 01/Nov/08 07:53 PM
This still seems to be broken in 1.21.6 (99587). When a newline appears after a word wrap, the first character after the wrap in every line before the newline is missing. Pretty visible when pasting notecards to chat.

Was the fix applied and broken, or not applied to the release viewer yet? Or should I file this as a new bug?


Domchi Underwood added a comment - 02/Nov/08 05:56 AM - edited
Confirmed, I've just tested this in 1.21.5 and it's not fixed. I'm reopening this issue.

Soft Linden added a comment - 18/Mar/09 02:07 PM
Ha. From maint-viewer-4 to maint-viewer-14. What an annoying wait.

Domchi Underwood added a comment - 09/Jun/09 04:42 PM - edited
I'm bumping this to critical, since it still hasn't been fixed in 1.23.3. Lindens, please include this fix in the next release, this is a major bug and it's a shame that it still isn't fixed. Especially considering that the fix was available few hours after the bug was reported, year and a half ago!

Soft Linden added a comment - 09/Jun/09 05:05 PM
@domchi - It's fixed in the maint-viewer branch, which is already scheduled to be in the next viewer release. Sorry this has taken so long - I'm way frustrated too.

Domchi Underwood added a comment - 09/Jun/09 05:08 PM
Thanks Soft!