• All submissions to this site are governed by Second Life Project Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.
MAINTENANCE ANNOUNCEMENT - JIRA will undergo maintenance starting 1:00am PDT through 3:00am on Saturday 2010.03.20. Please do not enter issues during this time as the system maybe restarted.
Issue Details (XML | Word | Printable)

Key: VWR-3321
Type: New Feature New Feature
Status: Resolved Resolved
Resolution: Fixed
Priority: Normal Normal
Assignee: Tofu Linden
Reporter: Subversive Writer
Votes: 15
Watchers: 3
Operations

If you were logged in you would be able to see more operations.
1. Second Life Viewer - VWR

"Turn voice off automatically when ending private chat / conference" option

Created: 19/Nov/07 04:19 PM   Updated: 15/Jun/09 04:52 PM
Component/s: Voice
Affects Version/s: 1.18.4.3
Fix Version/s: 1.23 Release Candidate, 1.23

Time Tracking:
Not Specified

File Attachments: 1. Text File VWR-3321-AutoDisengageVoice-V2.patch (5 kB)
2. Text File VWR-3321-AutoDisengageVoice.patch (5 kB)

Issue Links:
Relates
 

Last Triaged: 09/Nov/08 03:36 AM
Source Version: trunk
Linden Lab Issue ID: DEV-23536
Patch attached: Patch attached
Linden Lab Internal Branch: featurettes-9


 Description  « Hide
I had been in private voice chat with someone before we decided to switch over to MSN for videochat. After an hour or so of that, I realized I'd been broadcasting our private conversation to a room full of strangers, as I had been re-connected to inworld chat with my SL talk button still locked down.
Clearly my fault, but it would still be nice to have an option to unlock my talk button /automatically/ when switching between voice chats (this includes moving from one IM to a conference call)

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Aimee Trescothick added a comment - 07/Nov/08 06:22 PM
Much too easy to forget when leaving a private call.

Attached a patch to implement this, including a tick box on the voice preferences page in case anyone prefers the current behaviour.


Aimee Trescothick added a comment - 07/Nov/08 07:21 PM
Just noticed the patch fails to apply cleanly, that's only because panel_preferences_voice.xml has DOS style line endings.

Aimee Trescothick added a comment - 09/Nov/08 04:06 PM
This will need thorough testing to make sure it doesn't turn off the mic any time it's not supposed to. It's working fine for me so far, but I'm only one person, and not a big voice user

Aimee Trescothick added a comment - 09/Dec/08 08:09 PM
The previous patch was being slightly too aggressive and muting the mic whenever any IM window was closed.

New patch (VWR-3321-AutoDisengageVoice-V2.patch) attached which now only mutes the mic on returning to the spatial voice channel. This also leaves the mic switched on when switching directly from one IM call to another.

The new patch is also rebased to the current trunk, as changes to the voice preferences panel had broken the previous patch.


Aimee Trescothick added a comment - 09/Dec/08 08:36 PM
I'm not convinced moving between IM calls should mute the mic, personally I prefer it only muting on return to the spatial channel, which is what the patch now does.

I can see an argument for it when moving from a private call to a conference call, but in testing I found this just tends to lead to me talking for a while before realising no one can here me as the mic has muted.

Actively moving from one call to another you should be aware that your mic is open, so it is much less likely to be an issue than passively ending a call and returning to spatial voice, which may happen without any user action if the other party ends the call.


Aimee Trescothick added a comment - 10/Jan/09 12:21 PM
Just an update to say that V2 is working well.

Tofu Linden added a comment - 12/Jan/09 12:36 PM
The UI folks have decided that they'd rather make it much more obvious whether you're in public or private chat, than this behavioral change. Thanks for investigating, though!

Erica Linden added a comment - 12/Jan/09 12:37 PM
Hi guys - Identifying this problem was very helpful. I believe at the core, the problem stems from having invisible modes. There is currently no easy, at-a-glance way to know if you are speaking privately or publicly.

I'm closing this patch in favor of an internal issue which makes "Private Voice" mode and "Public Voice" mode more easily distinguishable.

Many thanks to you Aimee, and everyone who contributed.

*edit* looks like Tofu beat me to it.


Aimee Trescothick added a comment - 12/Jan/09 05:18 PM - edited
That's not the same problem though, and is unlikely to solve this issue.

One of the main situations in which this happens is when someone ends a call and immediately gets up and walks away from their computer to do something else. The rest of the world then hears them eating their lunch / feeding the dog / having a private conversation with their wife, or whatever.

Modal indication won't help with that. This is plain social conditioning from people being used to ending calls by hanging up the telephone, no UI indication (short of flashing the entire screen red) is going to change that, as their attention has already shifted away from the computer as soon as they hit the close button.

It could even happen without your intervention at all, if you are in a voice call and the other party ends the call while you've stepped away from your computer, that's a major privacy issue.


Subversive Writer added a comment - 13/Jan/09 01:37 AM
Agreed with Aimee: Indication of status is a COMPLETELY separate issue. The Example I gave was about ending the call and switching to another window. How is an indication in SL of my status meant to help when I'm not looking at SL?! The common case of "I'm done with voice chat, and doing something else now" seems like it wouldn't be helped at all by this proposed UI change.

Yeah, there's a problem with the UI, but I'd say the most glaring problem is that people have a big "End call" button that doesn't actually do what every other "End call" button on the planet does- End the use of the microphone!

Maybe re-label it to "Return to public voice" or something that actually says what it does, if you want to keep the same behavior


Subversive Writer added a comment - 13/Jan/09 01:38 AM - edited
as there seems to be more than one person who thinks a tangentially-related UI change is not the same thing, I request that this issue be re-opened. (it seems this actually re-opened the issue right away, rather than just sending a request. Sorry!)

Rob Linden added a comment - 14/Jan/09 08:55 AM
I think it'd be really helpful for someone to raise this issue on the sl-ux@ mailing list. This seems worth further discussion with a wider audience than is probably watching this issue.

Aimee Trescothick added a comment - 15/Jan/09 08:58 AM
OK, thanks Rob. I'll raise it on the list, and reopen again here so that people are able to come and vote if they so wish.

Jacek Antonelli added a comment - 15/Jan/09 09:58 AM
I agree with Aimee and Subversive, that UI indication alone is not a proper solution. UI indication isn't a bad thing, but it doesn't solve this particular problem by itself.

The main problem is that the current behavior is not what users expect, isn't consistent with the behavior of other voice apps, and honestly, doesn't make much sense.

Imagine if the telephone in your office would, whenever you hung up after a call, turn on speakerphone and start sending the sound of whatever you were doing to everyone else in the office. That would be a problem! Yes, the designer of the phone could add a light that turns on when it's doing that, but you'd still have to remember to hit a button to turn off that "feature" every time you hung up. And how many people would want that behavior in the first place?


McCabe Maxsted added a comment - 15/Jan/09 10:07 AM - edited
I agree with Aimee, Subversive, and Jacek. The problem is not UI indication, the problem is exactly what this patch solves: that when you're in a private chat with someone and you end the call (or, incidentally, when there's network problems), you suddenly get booted back into public chat. It's surprising to the user, particularly because "end call" is pretty much another way of saying "I don't want to talk anymore," but the system makes you talk anyway. Indication won't fix the system behaving badly.

Tofu Linden added a comment - 27/Jan/09 10:51 AM
Howdy, just letting you know that after having pushed this change around some more, we're totally planning on taking it. Thanks.

Tofu Linden added a comment - 27/Jan/09 02:35 PM
Thanks for the great patch, Aimee.
Thanks everyone for the feature suggestion and the ongoing discussion which made this landable.

Aimee Trescothick added a comment - 27/Jan/09 02:45 PM
Thank you

Coco Linden added a comment - 03/Feb/09 05:37 PM
Aimee rocks!!

Dessie Linden added a comment - 15/Jun/09 04:52 PM
Fixed in 1.23.4, released on 06/15/2009.