[#VWR-2948] Create XUI-based Advanced menu

1. Second Life Viewer - VWR

VWR-2896

Create XUI-based Advanced menu

Created: 02/Nov/07 05:30 PM Updated: 13/Nov/08 09:11 AM

Return to search

Component/s:

User Interface

Affects Version/s:

1.20 Release Candidate, 1.18.3.5, 1.18.4 Release Candidate

Fix Version/s:

None

File Attachments:

menu_viewer.xml (76 kB)
2.

menu_viewer_20080904.xml (96 kB)
3.

VWR-2948.patch.txt (67 kB)
4.

VWR-2948_xui_advanced_menu_20080708_clean.patch.txt (45 kB)
5.

VWR-2948_xui_advanced_menu_20080904.patch.txt (47 kB)

Issue Links:

Relates

This issue is related to by:

~~VWR-8056~~ PATCH: Clean up menu_viewer.xml (main menu XUI)

SVC-991 Meta Issue: Issues that aren't fixed yet

Last Triaged:	25/Sep/08 01:47 PM
Source Version:	1.20 RC12
Linden Lab Issue ID:	DEV-5486
Patch attached:	Patch attached
Linden Lab Internal Branch:	skinning-3

Description

« Hide

Add XML code to replace the Advanced menu removed by VWR-2947.

All

Comments

Change History

Sort Order:

[ Permlink | « Hide ]

Jacek Antonelli added a comment - 02/Nov/07 06:11 PM

I've tested every item in the Client menu (and its sub-menus) to make sure they functions the same as the hard-coded menus they are replacing, and I'm satisfied that the Client menu checks out. Others are welcome to confirm my tests.

There are two known differences: the Client > Render menu now always shows the "HTTP Get Textures" and "Dynamic Reflections" menu items. Normally, they are hidden in "release for download" builds.

Of course, I could not test that the new Server menu functions the same as the old one, since I can't use them. A Linden with customer-service level God powers should check to make sure they all work properly.

[ Permlink | « Hide ]

Jacek Antonelli added a comment - 10/Jul/08 08:59 PM - edited

Updated this issue and attached a new patch, VWR-2948_xui_advanced_menu_20080708_clean.patch.txt.

The new patch applies to 1.20 RC12, but the patch line numbers depend on ~~VWR-8056~~. You can kill two birds with one stone by replacing the current menu_viewer.xml with the attached version (it contains the changes from both ~~VWR-8056~~ and this VWR-2948 patch).

The new patch has been updated to include all current menu items in the Advanced menu. It does not contain menu entries for the Admin menu, as I left those C++ based in the new patch for VWR-2947.

The XUI menu is functionally and visually equivalent to the C+-based menus, and I have personally tested every menu item multiple times to make sure of that. The only visible difference is that I have made "HTTP Get Textures" included all the time, whereas it had been conditionally removed at compile time with the C+ menus. The XML for that menu item could be commented out if there's some reason to have it disabled.

The old patch is obsolete and should not be used.

[ Permlink | « Hide ]

Jacek Antonelli added a comment - 04/Sep/08 01:40 PM

Updated the patch and XML:

VWR-2948_xui_advanced_menu_20080904.patch.txt
menu_viewer_20080904.xml

Since ~~VWR-8056~~ was resolved Won't Fix, I've applied the changes to the non-cleaned up menu XML and generated a new XML patch that will apply to the 1.20 release out of the box. ~~VWR-2497~~ still works fine.