• All submissions to this site are governed by Second Life Project Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.
Issue Details (XML | Word | Printable)

Key: VWR-2524
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Tofu Linden
Reporter: Nicholaz Beresford
Votes: 2
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
1. Second Life Viewer - VWR

Possible crash on startup with group messages waiting (llnotify.cpp)

Created: 19/Sep/07 07:27 AM   Updated: 30/Nov/07 07:19 AM
Return to search
Component/s: Crashes
Affects Version/s: 1.18.3 Release Candidate, 1.18.2.0
Fix Version/s: Source code

File Attachments: 1. Text File 2524_possible_crash_on_login_llnotify.patch (1 kB)

Issue Links:
Duplicate
 
Relates
 

Linden Lab Issue ID: SL-56676
Patch attached: Patch attached


 Description  « Hide
I had reports and crash dumps from users who were crashing directly on login.

The position of the crash is llnotify.ccp inside
void LLNotifyBox::moveToBack()
at
front->mNextBtn->setFocus(TRUE);

Looking at the dump showed that the returned "front" wasn't a LLNotifyBox but a LLGroupNotifyBox.

The error goes down to a bad assumption inside LLNotifyBox * LLNotifyBoxView::getFirstNontipBox() const where the function expects all childs to be of type LLNotifyBox which is obviously not true because group notifications are also added to gNotifyBoxView (see llgroupnotify.cpp);

The attached patch is more like a band aid or a sample to highlight the problem, someone who knows what he's doing will probably come up with a better method.

As a side note, there's also an assumption in moveToBack which is not true

// assuming that moveToBack is only called by clicking the next button,
// we give focus to the next next button

as the function is now called when a new box opens (and in those cases on login without any user interaction).



 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
Nicholaz Beresford made changes - 19/Sep/07 07:32 AM
Field Original Value New Value
Attachment 2524_possible_crash_on_login_llnotify.patch [ 12016 ]
Nicholaz Beresford made changes - 26/Sep/07 10:33 AM
Link This issue is related to by VWR-2046 [ VWR-2046 ]
lindenrobot made changes - 01/Oct/07 04:25 PM
Linden Lab Issue ID SL-56676
Tofu Linden made changes - 02/Oct/07 02:50 AM
Assignee Tofu Linden [ Tofu Linden ]
Tofu Linden made changes - 02/Oct/07 02:51 AM
Status Open [ 1 ] In Progress [ 3 ]
Tofu Linden made changes - 02/Oct/07 03:46 AM
Status In Progress [ 3 ] Resolved [ 5 ]
Fix Version/s Source code [ 10012 ]
Resolution Fixed Internally [ 7 ]
Torley Linden made changes - 10/Oct/07 03:38 PM
Link This issue is duplicated by VWR-2474 [ VWR-2474 ]
Nicholaz Beresford made changes - 30/Nov/07 07:18 AM
Resolution Fixed Internally [ 7 ]
Status Resolved [ 5 ] Reopened [ 4 ]
Nicholaz Beresford made changes - 30/Nov/07 07:18 AM
Status Reopened [ 4 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Nicholaz Beresford made changes - 30/Nov/07 07:19 AM
Status Resolved [ 5 ] Closed [ 6 ]
Rob Linden made changes - 22/Dec/07 03:36 AM
Workflow jira [ 15413 ] jira-2007-12-21 [ 29555 ]
Rob Linden made changes - 22/Dec/07 04:08 PM
Workflow jira-2007-12-21 [ 29555 ] jira-2007-12-22 [ 36478 ]
Rob Linden made changes - 22/Dec/07 11:12 PM
Workflow jira-2007-12-22 [ 36478 ] jira-2007-12-22a [ 47653 ]
Sue Linden made changes - 13/Nov/08 11:42 AM
Workflow jira-2007-12-22a [ 47653 ] jira-2008-11-14 [ 75786 ]
Sue Linden made changes - 13/Nov/08 06:42 PM
Workflow jira-2008-11-14 [ 75786 ] jira-2008-11-14a [ 134365 ]