• All submissions to this site are governed by Second Life Project Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.
Issue Details (XML | Word | Printable)

Key: VWR-2524
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Tofu Linden
Reporter: Nicholaz Beresford
Votes: 2
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
1. Second Life Viewer - VWR

Possible crash on startup with group messages waiting (llnotify.cpp)

Created: 19/Sep/07 07:27 AM   Updated: 30/Nov/07 07:19 AM
Return to search
Component/s: Crashes
Affects Version/s: 1.18.3 Release Candidate, 1.18.2.0
Fix Version/s: Source code

File Attachments: 1. Text File 2524_possible_crash_on_login_llnotify.patch (1 kB)

Issue Links:
Duplicate
 
Relates
 

Linden Lab Issue ID: SL-56676
Patch attached: Patch attached


 Description  « Hide
I had reports and crash dumps from users who were crashing directly on login.

The position of the crash is llnotify.ccp inside
void LLNotifyBox::moveToBack()
at
front->mNextBtn->setFocus(TRUE);

Looking at the dump showed that the returned "front" wasn't a LLNotifyBox but a LLGroupNotifyBox.

The error goes down to a bad assumption inside LLNotifyBox * LLNotifyBoxView::getFirstNontipBox() const where the function expects all childs to be of type LLNotifyBox which is obviously not true because group notifications are also added to gNotifyBoxView (see llgroupnotify.cpp);

The attached patch is more like a band aid or a sample to highlight the problem, someone who knows what he's doing will probably come up with a better method.

As a side note, there's also an assumption in moveToBack which is not true

// assuming that moveToBack is only called by clicking the next button,
// we give focus to the next next button

as the function is now called when a new box opens (and in those cases on login without any user interaction).



 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
Nicholaz Beresford added a comment - 19/Sep/07 07:32 AM

This is a dry patch at the moment (not tested or verified).

Lex Neva added a comment - 20/Sep/07 09:11 AM
Does the crash happen repeatedly, or only once? In other words, is the group notice cleared by logging in and crashing once, or does it stick around and crash you next time?

Nicholaz Beresford added a comment - 22/Sep/07 06:04 AM
Lex,

as far as I can tell only once. The user who reported it could then log in on the next attempt.

But I found that most likely this also happens in session when a notification (inventory offer, friend offer) comes in while there's still a group message on screen.


Nicholaz Beresford added a comment - 22/Sep/07 06:04 AM

The patch is now running in my viewer for a few days and seems to have cured the problem for the user who reported the login crash.

Nicholaz Beresford added a comment - 26/Sep/07 10:34 AM

When applying the patch, please also see VRW-2046. Because the patches would l collide, I included this patch into the VWR-2046 too.

Tofu Linden added a comment - 02/Oct/07 03:46 AM
Upon investigation, this was already fixed internally, actually using a very similar change to yours - thanks though!