|
|
|
[
Permlink
| « Hide
]
Gigs Taggart added a comment - 22/Apr/07 10:58 PM
No reproduction on mac, must be Windows specific.
I've been working on this issue. The attached patch IME-20070716.patch is the latest snapshot. It is against 1.18.0.6 source files.
The patch makes the viewer Please not that this is just a snap shot from my own development. It mostly works, but it has some problems. I don't think the patch is ready for merge into the SL release source tree. It should be considered as something like a "technology preview" or "concept prover". For those who are lazy, I put pre-build binary (main executables only) that integrates this path on my blog site. Windows binary is at http://alissa-sabre.cocolog-nifty.com/files/IME-20070716-Win32.zip Have fun and stay tuned Discussed on Internationalization Triage, 2007-07-27. http://wiki.secondlife.com/wiki/Bug_triage/2007-07-27/Transcript#VWR-250:_Preedit_.28composition.29_strings_are_shown_poorly_when_typing_Japanese_text_on_Windows
 I updated the experimental/preliminary patch. It is attached to this issue as IME-20070819.patch. It is against 1.18.2.0 source. The patch works on both Windows and MacOS.
I think that it is not yet ready for import. You can try it by applying the patch and build the viewer by yourself, or you can download the pre-compiled binary from my blog site. http://alissa-sabre.cocolog-nifty.com/files/IME-20070819-Win32.zip I'm attaching a new patch. It is against 1.18.3(2)RC.
Some more bugs regarding input method handling are fixed. I have a feeling that the patch is fairly stable now and is ready for inclusion in a beta version. (I don't think it is ready for inclusion in a RC/Release viewers, however.) My own build is available on my blog site as always. Windows binary is at http://alissa-sabre.cocolog-nifty.com/files/IME-20070909-Win32.zip I made a mistake on creating the ime-20070909.patch. So, I re-created the patch and uploaded it with the same name, hoping the new one replaces the old one. The result was: two patches of the same file name are listed.
SOrry for the confusion. The newer patch is http://jira.secondlife.com/secure/attachment/11891/ime-20070909.patch Note that the patch adds a new file, linden/indra/llwindow/llpreeditor.h, so you need to adjust your project to include it. Also note that this patch file includes those for Hi Alissa - I dug into the patch, and it looks like there is a lot of good code in there, but also a lot of extra stuff unrelated to the Japanese input issues. Could you make a bundle with your latest versions of these files:
linden/indra/llcommon/llstring.cpp It will be easier to merge and understand what you've done with the full source files. Thanks! The file changed-files-20070915.zip contains all files that have been changed to fix the input method issue. These files are based on 1.18.3.2 RC source files. I removed all changes that are not related to input method handling. All of these changes are required to provide better_preedit_handling.
These chagnes include what are only necessary to support some advanced input method features. They also include some changes that are necessary only in Chinese or Korean input method. So, they contain more than a minimum fix to the issue originally reported as Thanks a lot, Alissa! The 20070909 patch works on my computer.
My environment: With Alissa's patched EXE, when I began chatting my traditional and simplified Chinese characters appeared directly in the text caret, just as they would in most Windows applications. They no longer go to a small temporary box which is usually far away from the Chat input field. And, the phrase assisting(to allow the user to select candidate words and phrases from the IME's lexicon when typing)of these Microsoft Windows IMEs (Ch Traditional, Ch Simplified, Japanese) is functional with Alissa's patched SL viewer. I believe this is the user experience most CJK users would want. This should end up in the 1.18.5 viewer. I think it missed the merge into release and 1.18.4
Thanks for the great OS contribution. This will really move our Japanese support forward, as we now work much better with the input systems. The new patch, ime-20071110.patch, is the updated patch against 1.18.4(3) sources. It is both for Windows and MacOS.
Have fun. SL viewer binaries with this patch is ready for download.
For Windows users: http://alissa-sabre.cocolog-nifty.com/files/IME-20071110-Win32.zip I understand that the change planned on 1.18.5 is delayed to 1.19.0. I'm waiting for the 1.19.0 viewer.
I found a Macintosh only problem in my 20071110 patch. 20071123a fixes it.
... Finally I found that the good old system 7 compatible KeyScript() works best even on OSX 10.4! I made a mistake and introduced a new bug in my patch 20071123a. The bug is: When there is a selected text, typing some text using input method does not replace the selected text.
The fix is supplied as the patch ime-20071124. I'm attaching an updated patch against 1.18.5.3, ime-20071201.patch. This patch should contain exactly the same changes as ime-20071123 + ime-20071124.
This patch is primariry for open source developers. I don't think this patch upload doesn't facilitetae Lindens, since I believe that the equivalent changes should have been integrated into the Linden's internal source repository already, although I have no way to verify it until LL discloses it... This issue has been bulk changed to fix pending.
Removed Affects Version/s of "First Look: WindLight" – as it says when you're editing an issue, "ONLY select a "First Look" if this issue ONLY affects that version." We do this to better focus on FL-specific issues. Thanks! Well finally!
I tested 1.19.0 RC1 viewer and found this issue is completely fixed (on Windows and MacOS). Thank you for the fix. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 |
|
Bug
Closed
Major
Preedit (composition) strings are shown poorly when typing Japanese text on Windows
