• All submissions to this site are governed by Second Life Project Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.
Issue Details (XML | Word | Printable)

Key: VWR-2488
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Normal Normal
Assignee: Soft Linden
Reporter: Seg Baphomet
Votes: 2
Watchers: 3
Operations

If you were logged in you would be able to see more operations.
1. Second Life Viewer - VWR

Standalone build is almost, but not quite there.

Created: 16/Sep/07 09:31 AM   Updated: 19/Feb/08 02:19 PM
Return to search
Component/s: Source Code
Affects Version/s: Source code
Fix Version/s: None

File Attachments: 1. Text File slviewer-1.18.3.2-use-pkg-config.patch (1 kB)
2. Text File slviewer-1.18.3.5-fix-manifest-for-amd64-standalone.patch (1 kB)
3. Text File slviewer-1.18.5.1-standalone_build_fixes.patch (3 kB)
4. Text File slviewer-1.18.5.1-standalone_expat_includes.patch (0.5 kB)

Environment: Fedora 7, Debian SId
Issue Links:
Relates
 

Source Version: 1.18.3.2
Linden Lab Issue ID: SL-55947
Patch attached: Patch attached


 Description  « Hide
Almost there. Standalone build still needs some tweaks. The expat header isn't included properly, and there's really no need to pkgconfig things slviewer isn't directly using. Asking for GTK automatically pulls in everything GTK needs. Asking for minimal deps is better for portability, and compatibility with future versions of GTK. Also, gstreamer is missing.

Still needed in 1.18.3.4



 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
Michelle2 Zenovka added a comment - 21/Sep/07 01:28 AM
And still present in 1.18.3.5, there are some other issues with standalone building as well particular on the amd64 platform. The viewer_manifest.py is failing to package the viewer correctly , I attach a patch slviewer-1.18.3.5-fix-manifest-for-amd64-standalone.patch that fixes the packaging as well and combined this patch and Seg;s patch will allow standalone builds on AMD64 as well as i686 linux.

Michelle2 Zenovka added a comment - 21/Sep/07 02:30 AM
Oh will just add that VWR-1853 also blocks a true standalone build due to no packaged fonts and non distributable fonts.

Michelle2 Zenovka added a comment - 21/Oct/07 03:21 AM
Still present in 1.18.4.0

Michelle2 Zenovka added a comment - 20/Nov/07 04:56 AM
Updated patch that combines both patches together, rebased for 1.18.5.1. Also the gstreamer pkg-config stuff is only applied if standalone is yes. It now does not trample over non standalone settings. So its valid for standalone and non standalone builds now.

Michelle2 Zenovka added a comment - 20/Nov/07 05:31 AM
Oh and the expat.h header fix for standalone as well

Sardonyx Linden added a comment - 28/Nov/07 01:06 PM
I can't do anything about this in the immediate term, as there's a Mesa bug on Fedora 8 that kills the X server when I run SL.

Seg Baphomet added a comment - 01/Dec/07 05:13 PM
Killing the X server sounds more like a hardware driver bug than a Mesa bug. What hardware?

Soft Linden added a comment - 04/Jan/08 08:58 AM
Please consider making this a meta task and moving issues to individual JIRAs. I'd like to take some of this, but don't want to hijack Sardonyx (external owner) or Tofu (internal owner). I don't know which they really want from this.

Sardonyx Linden added a comment - 04/Jan/08 10:37 AM
I have a clean 64-bit build working on Fedora 8 under the CMake branch. My focus is on getting that working, so I won't be looking at patches against SConstruct. Its days are numbered.

Tofu Linden added a comment - 04/Jan/08 10:43 AM
-> Soft !

Michelle2 Zenovka added a comment - 10/Jan/08 07:46 AM
Thanks Sardonyx,

I think these patches can just stay here as a reference until cmake is released then its time for another around of patches on a new bug. As you say SConstruct's days are numbered and there is not much point spending time here with a new build system on the Horizon. Tofu and Soft do you agree here? Or are there still bits you would like to apply in the short term? It depends on your internal time table for cmake.


Soft Linden added a comment - 10/Jan/08 08:18 AM - edited
The SConstruct stuff is of marginal utility, but minor enough to still take.

The manifest and include locations we want regardless. I'll pick the relevant bits out and mark the meta issue resolved. For any new fixes, please create new issues and link them to this - don't attach more patches here: They're guaranteed to get overlooked without separate tracking.


Michelle2 Zenovka added a comment - 16/Jan/08 04:58 AM
For anyone tracking.... The manifest stuff hit the public tree at 1.18.6.4. The other bits have not made it yet, and the bit that has been applied was my patch and Seg got the credit , hehe never mind

Soft Linden added a comment - 16/Jan/08 06:32 AM
Oof - I'll fix the credit. There's another bit coming off this that's probably Seg's with your name on it, filed under this same JIRA.

Sardonyx Linden added a comment - 19/Feb/08 01:42 PM
I'd really like to close the remainder of this out and open new issues against whatever bits are not fixed yet on the cmake branch. Can you all help out with this, please?

Soft Linden added a comment - 19/Feb/08 02:19 PM
The relevant ones went in