• All submissions to this site are governed by Second Life Project Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.
MAINTENANCE ANNOUNCEMENT - JIRA will undergo maintenance starting 1:00am PDT through 3:00am on Saturday 2010.03.20. Please do not enter issues during this time as the system maybe restarted.
Issue Details (XML | Word | Printable)

Key: VWR-2331
Type: New Feature New Feature
Status: Resolved Resolved
Resolution: Fixed
Priority: Normal Normal
Assignee: Which Linden
Reporter: Gigs Taggart
Votes: 20
Watchers: 5
Operations

If you were logged in you would be able to see more operations.
1. Second Life Viewer - VWR

Terraform tool variable "strength"

Created: 05/Sep/07 02:11 PM   Updated: 19/Oct/08 02:09 PM
Component/s: User Interface
Affects Version/s: Source code
Fix Version/s: 1.21 Release Candidate, 1.21

Time Tracking:
Not Specified

File Attachments: 1. Text File slviewer-v120RC1-TerraformForce.patch (6 kB)
2. Text File terraform-force.patch (6 kB)
3. Text File terraform_updated.patch (6 kB)
4. Text File VWR_2331_terraformforce_featurettes.patch (6 kB)

Image Attachments:

1. new_terraform_gui.png
(45 kB)

2. safer-terraform-gui.jpg
(27 kB)

3. safer-terraform-gui2.jpg
(32 kB)

4. terraform-gui.png
(125 kB)

5. This was difficult to get lined up to show the differences in build height. .jpg
(313 kB)
Environment: All
Issue Links:
Relates

Source Version: 1.18.3.4RC
Linden Lab Issue ID: DEV-2491
Patch attached: Patch attached
Linden Lab Internal Branch: featurettes-1


 Description  « Hide
This feature would allow the user to select how strongly the selected terraform tool affects the land being terraformed.

I will be implementing this feature real soon now.



 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Gigs Taggart added a comment - 18/Sep/07 02:18 AM
Patchy!

Obviously there's a lot of tweakables here. The lowest setting is about half of the current tools, the highest is about 20x as powerful for brushes, about 5 times as powerful for raise/lower selection.

Note that some "selection" operations ignore the strength parameter on the server side (such as roughen).


McCabe Maxsted added a comment - 18/Sep/07 07:57 AM
Awesome! So does this mean the flatten land tool can actually flatten now?

Gigs Taggart added a comment - 18/Sep/07 01:57 PM
Yes, very quickly

orion raymaker added a comment - 18/Sep/07 03:28 PM
Seen it in action, very smooth and works a treat superb

Soft Linden added a comment - 03/Jan/08 09:06 AM
If this is assigned, it won't show up in searches when Lindens are looking for unclaimed issues

Mako Minogue added a comment - 03/Jan/08 08:14 PM
It would be most helpful if we could set the selected land's absolute target Z in meters by "the numbers". It's insanely difficult to do stuff by some vaguely defined "force". Give us access to the numbers please.

Gigs Taggart added a comment - 09/Feb/08 07:23 PM
new patch with log scale

Aimee Trescothick added a comment - 17/Apr/08 06:08 PM
Version of Gig's patch for 1.20 RC1

Which Linden added a comment - 24/Apr/08 06:43 PM
I will take on the incorporation of this patch, or at least give feedback on its status. This will likely be a slow process as I am not primarily a viewer developer any more.

The internal JIRA contains this recommendation from the Rx team:

  • Change the order of these controls to: Paintbrush dropdown, Force slider, Apply to Selection button, and Show Owners checkbox.
  • Change Force slider to Strength.

Pretty minor.


Which Linden added a comment - 06/May/08 04:31 PM
Attached patch containing reordered ui elements per RX, generated against our internal featurettes branch. Should still work against most branches.

Which Linden added a comment - 06/May/08 04:33 PM
Screenshot of the rearranged UI (Dazzle skin, natch). Thorough!

Gigs Taggart added a comment - 06/May/08 06:04 PM
Thanks for working on this. This plus the new snapshot options patch will really remove two thorns from my side that I have to deal with whenever I use a linden build.

Which Linden added a comment - 08/May/08 02:17 PM
I found some small bugs relating to the storage of the force setting – some of the code was confused whether the stored setting was the logarithm or the actual force. Corrected patch attached.

Which Linden added a comment - 08/May/08 02:19 PM
Committed to the featurettes branch. Realistically it will probably be at least a month before it percolates out to a public viewer.

Aimee Trescothick added a comment - 08/May/08 02:54 PM
While you're shuffling the terrain tools around, would you mind taking a look at VWR-3242? Moving the Apply to Selection button below the Force slider alleviates it to some extent, but having it where it gets covered by the drop down is still a problem, as it's far too easy to click by accident, with potentially disastrous results.

Aimee Trescothick added a comment - 24/May/08 11:50 AM
Attached screenshot (safer-terraform-gui.png) of suggested safer, more logical and less cramped GUI.

1) Apply to selection opposite Select Land and spaced away from other controls.

2) Brush controls grouped together with a heading.

3) Slider renamed to Strength.

4) "Show Owners" moved to Advanced controls.

5) Advanced controls grouped logically.


Gigs Taggart added a comment - 24/May/08 03:23 PM
To step back a minute... I'm not sure it makes sense to have redundant buttons here for abandon land, about land, and buy land. Show owners is probably best moved to the view menu.

Aimee Trescothick added a comment - 24/May/08 07:57 PM - edited
I'd happily lose the Buy and Abandon buttons, but I do use the About button there while joining and subdividing parcels.

Show Owners is already a redundant copy of of View>Land Owners. Neither name is a particularly good description of what it does. For that reason I moved it down to the "Advanced" area, definitely advanced anyway as you have to know what the colours mean. Hesitate to remove it completely though; while it's not particularly useful, you can guarantee there's SOMEONE that uses it all the time and it's not like the lower part of the window is short on space at the moment.

I had a bit more of a play this evening, and ended up with safer-terraform-gui2.

1) Changed the brush size into a slider rather than a combo. Less clicks and takes up less space.

1) Trimmed "Land" off the end of the radio buttons, except the first. These are all a bit crowded still. In purist terms should probably be icons (with tool tips), but that's lots more work and would hold things up.

2) Moved the parcel area with the other parcel info stuff.

3) Renamed Show Owners to Show Status, with a tool tip to clarify a bit. It's meaningless unless you know what the different colours signify, so added a "?" button next to it which should display a colour key. The View>Land Owners menu item should probably also be renamed as Show Parcel Status to match.

4) Added titles to the sections, though I'm not convinced whether that's helpful or just clutter.


Qarl Linden added a comment - 24/Jun/08 04:11 PM
GIGS! you stole my featurette!

i just sat down to implement a strength slider in the terraform tool - and i was stunned to see there's already one in there.

great minds think alike.

or something.


Gigs Taggart added a comment - 24/Jun/08 06:35 PM
Heh, you could polish this one a little bit if you want on the server side. The server reacts badly to certain fields having a large value for "seconds" in the packet.

The server seems to discard the seconds parameter for "smooth selection". For "revert selection", if it is given a large seconds value, the land takes on random values in my experimentation.

I believe all the brushes respond well to this patch, but the selection/area tools have trouble on the server end.

For this patch I just made the force slider not apply to packets that the server did strange things with, so this patch is still good to go, but it could use that server side polish if you want.


Shibari Twine added a comment - 28/Aug/08 05:55 PM
WooHoo Accepted.

I love this patch (terraforming in SL is my "job") and will be glad to see it make the official viewer.


Samantha Glume added a comment - 06/Sep/08 11:47 AM
Was playing around with the strength slider and found an issue (1.21rc1). If you set the strength slider to MAX and use REVERT to revert land that is slightly off of the default it goes WILD. I have spires reaching 200m in the air on mainland and some go all the way down to 0.

I am leaving a sample here http://slurl.com/secondlife/Dimitrios/101/99/51 .

No body better AR me for leaving this proof of bug here...


Gigs Taggart added a comment - 07/Sep/08 02:39 PM - edited
This was a known issue that I discovered during the development of this patch about 8 months ago. At that time I filed a report with security@lindenlab.com, as well as reporting it in person to several lindens, letting them know the griefing potential of this.

My original patch deliberately ignored the power setting when select land revert was used, to avoid triggering this bug prior to it being fixed. Somehow that was lost in the process of merging this to Linden code.

(The real fix for this of course is to fix the server side)


Atashi Toshihiko added a comment - 17/Sep/08 04:00 PM
One of my estate managers was showing me the glitch today with the revert tool. She was able to make a hole down to 'zero' altitude, and after that, the terrain's raw file appeared to be corrupted. I downloaded it to see what it looked like, and both the height field and the multiply field were entirely at zero (black). I restarted the region, and after that the hole had turned into a 512m high spire, so I downloaded the raw file again to see if it was different. Still both height and multiply were entirely zero – this is for the entire region mind you, not just the parcel she was using to demonstrate.

Just thought I'd pass this along, since it definately seems to have a serverside component to the problem.


Gigs Taggart added a comment - 17/Sep/08 04:14 PM
It's entirely server side. The client can "hide" the problem like it did before these new tools were added, but the fix has to happen on the server side.

Which Linden added a comment - 17/Sep/08 04:51 PM
Hey, can y'all create a separate SVC issue for the wild n' crazy Revert behavior? I agree with Gigs – the server-side fix is the real one. We could remove the slider control from the Revert tool, too, I guess, but that seems like a paper fix.

Gigs Taggart added a comment - 17/Sep/08 05:51 PM