• All submissions to this site are governed by Second Life Project Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.
Issue Details (XML | Word | Printable)

Key: VWR-2085
Type: Bug Bug
Status: Fix Pending Fix Pending
Priority: Critical Critical
Assignee: Soft Linden
Reporter: Surfwidow Beaumont
Votes: 23
Watchers: 11
Operations

If you were logged in you would be able to see more operations.
1. Second Life Viewer - VWR

Ctrl-Alt-F1 Hide/Show UI Does Not Work Correctly Under Linux

Created: 08/Aug/07 07:45 AM   Updated: 29/May/09 07:59 AM
Return to search
Component/s: User Interface
Affects Version/s: 1.20, 1.18.1.2, 1.21 Release Candidate, 1.21, 1.22
Fix Version/s: None

File Attachments: 1. Text File shortcutfix.patch (8 kB)
2. File slviewer-0-v12160-LinuxShortcuts.patch.bz2 (0.8 kB)
3. Text File VWR-2085.patch (0.7 kB)

Image Attachments:

1. UIshortcut.jpg
(53 kB)
Environment: Linux.
Issue Links:
Duplicate
 
Relates

Last Triaged: 23/Oct/08 09:13 AM
Source Version: 1.18.1.2
Linden Lab Issue ID: DEV-12516
Patch attached: Patch attached
Linden Lab Internal Branch: maint-viewer-12


 Description  « Hide
Ctrl-Alt-F1 Hide/Show UI

Doesn't toggle the UI since release of new viewer

Serious for filming in SL

(Support ticket number from LLID field: rt.lindenlab.com #936546)



 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
Nicholaz Beresford added a comment - 08/Aug/07 07:58 AM

If you look at the debug menus, you'll see that the shortcut changed to Ctrl+Alt+F1

Lex Neva added a comment - 08/Aug/07 10:09 AM
Oh lord, I use that shortcut all the time. How could they just change it on us without even mentioning it in the release notes? :o

Lex Neva added a comment - 08/Aug/07 10:09 AM
Oh, wait, I thought we were talking about control-SHIFT-1, the stats panel.

Nicholaz Beresford added a comment - 08/Aug/07 10:48 AM
Some of the Ctrl+Atl+Digit combos were interfering with brackets on European keyboards (accidentally triggering the render features when typing "{ [ ] }" ).

Elbereth Witte added a comment - 12/Aug/07 08:07 AM
As a linux user, this just bit me hard a couple hours ago.

Could stuff that absolutely requires a hotkey (like show UI does) be moved out of the ctrl-alt f-key range?


Benja Kepler added a comment - 17/Aug/07 12:33 PM
This is a shortcut to a menu option.

So the thing to do is to look at the menu item, that this is a shortcut for.

Then you see that it has been changed.

So is this a bug? Or should there be bug like 'shortcut changed without mention in Release Notes'?


Stephen Zenith added a comment - 13/Oct/07 03:59 PM
Benja, the problem is that it's been changed to a combo on Linux that does something else - and does it with a higher priority.

Ctrl-Alt-F1 changes to the first virtual terminal, while X (and therefore SL) usually run on VT6 or 7, depending on the distribution. And because you've disabled the GUI, you have no way to re-enable it on Linux without killing the SL process and restarting SL.


Opensource Obscure added a comment - 13/Nov/07 07:17 PM
I confirm this issue as a bug.

You can't Hide/Show UI using UI (actually, you can't Show it back - since you do not know where to click),
and you can't do it using a shortcut (because the current one is almost unusable on all Linux systems, see previous comment).

it would be pretty easy to solve it by choosing a different shortkey.

Machinima making and the whole SL experience would be improved (for Linux users) by re-enabling Hide/Show UI.


Opensource Obscure added a comment - 09/Dec/07 11:05 AM
VWR-2896 would probably solve / provide a workaround for this bug, as Linux users would be able to change the shortcut themselves.

Opensource Obscure added a comment - 02/Feb/08 07:32 AM - edited
I managed to change this shortcut from CTRL ALT F1 to CTRL F1 recompiling the client from sources.
This is not the best solution, since many people still use CTRL F1 in their desktop environment shortcuts - but usually you can easily change/remove it, while I couldn't change CTRL ALT F1.

In linden/indra/newview/llviewermenu.cpp , I changed TO

sub_menu->append(new LLMenuItemCheckGL("UI",
&LLPipeline::toggleRenderDebugFeature, NULL,
&LLPipeline::toggleRenderDebugFeatureControl,
(void*)LLPipeline::RENDER_DEBUG_FEATURE_UI, KEY_F1, MASK_CONTROL));

FROM:

sub_menu->append(new LLMenuItemCheckGL("UI",
&LLPipeline::toggleRenderDebugFeature, NULL,
&LLPipeline::toggleRenderDebugFeatureControl,
(void*)LLPipeline::RENDER_DEBUG_FEATURE_UI, KEY_F1, MASK_ALT|MASK_CONTROL));

I am not a developer and unfortunately I do not know how to make/submit a patch.
I also think that a better shortcut than mine should be chosen.

Note:
A similar issue still breaks other shortcuts in Client > Rendering > Features


Surfwidow Beaumont added a comment - 28/Feb/08 09:12 AM
Common get the CTRL+ALT+F1 WORKING AGAIN hide show UI

I NEED TO MAKE MOVIES IN WINDLIGHT

groan - this is so important for people in SL to get right it should be the first thing you do before messing with the sky even :\

fingers crossed you sort it in the next release


Celierra Darling added a comment - 17/Mar/08 11:59 PM
Moved invalid LLID to description

Nefertiti Nefarious added a comment - 04/Apr/08 08:42 PM
CTRL-ALT-F1 kills my entire GUI because it shuts down the whole graphics system and goes back to text mode.

Recompiling from source is not exactly a work-around.

I am trying to make a machinima ... and If I hide the UI using the menu I have to kill SL and restart to get the menu back.

THIS IS CRITICAL FOR LINUX USERS!!!!!!


Opensource Obscure added a comment - 10/May/08 10:01 AM - edited
here's a diff that shows how to solve this issue.
the new shortcuts provided here is CTRL ALT 1 instead of CTRL ALT F1.
(first, the new proposed version; then, the old version that the official client is featuring right now)

diff indra/newview/llviewermenu.cpp indra/newview/llviewermenu.cpp.orig

1296c1296
< (void*)LLPipeline::RENDER_DEBUG_FEATURE_UI, '1', MASK_ALT|MASK_CONTROL));

> (void*)LLPipeline::RENDER_DEBUG_FEATURE_UI, KEY_F1, MASK_ALT|MASK_CONTROL));


Nefertiti Nefarious added a comment - 10/May/08 03:25 PM
Opensource Obscure:

diff indra/newview/llviewermenu.cpp indra/newview/llviewermenu.cpp.orig
1296c1296
< (void*)LLPipeline::RENDER_DEBUG_FEATURE_UI, '1', MASK_ALT|MASK_CONTROL));

> (void*)LLPipeline::RENDER_DEBUG_FEATURE_UI, KEY_F1, MASK_ALT|MASK_CONTROL));

Can you explain what all that means and how to use it?


Boroondas Gupte added a comment - 10/May/08 03:50 PM
This means that to get from the file newview/llviewermenu.cpp (in the indra/newview directory of the source code) to the file llviewermenu.cpp.orig (in the same directory), you have to replace '1' with KEY-F1 at line 1296. To get from the .orig (probably the original as distributed by Linden Lab) file to the other one (Opensource Obscure's modified version) just reverse that replacement. Then (re)compile the viewer.

Compiling SecondLife from source isn't trivial, but should get easier in the future. Since then, refer to the page for your OS linked at http://wiki.secondlife.com/wiki/Get_source_and_compile#Compiling
Before applying any patches (that's what developers call change sets, like the one you were just wondering about), try to successfully compile the unmodified source first. Instead of reading the patches and applying them by editing the corresponding source files, you can apply them via `patch' command. (See http://wiki.secondlife.com/wiki/Submitting_code#Applying_patches_to_your_source and http://en.wikipedia.org/wiki/Patch_(Unix) )


Opensource Obscure added a comment - 11/May/08 05:31 AM
Like Boroondas Gupte said (thanks for explaining it).

PLEASE NOTE though that you have to replace KEY-F1 with '1' at line 1296 in llviewermenu.cpp - not viceversa.

I edited my previous comment - I apologize for not being clear.

Right now, compiling the SL viewer from source on Linux is really painful. As Boroondas Gupte said, this should get easier in the future.


McCabe Maxsted added a comment - 26/Jun/08 06:22 AM - edited
I see two methods of solving this:
1. Longer term. Convert the advanced menu to XML and maintain a separate menu_viewer.xml for macs and linux. This would be fantastic, and a real benefit to we tinkerers. Longer development time, though.
2. Short term. Create new set of shortcuts.

Anyone have any recommendations for ones that'll work on all systems (linux/mac/windows)? I'll attach a patch if someone can give me a good list, but I don't have a linux box right now to test them under.


Opensource Obscure added a comment - 29/Aug/08 05:10 AM
I just enabled 'Patch attached' for this issue (even if actually no real patch files are attached) because this problem can be solved by changing the shortcut from CTRL ALT F1 to CTRL ALT 1, and this is a trivial change.

AFAIK, this new shortcut doesn't interfere with existing shortcuts on Linux and Windows - I couldn't test it on Mac OS X.

  • edit indra/newview/llviewermenu.cpp
  • find this string:
    KEY_F1
  • replace it with:
    '1'
  • build the viewer as usual
  • hide the UI and make it reappear by pressing CTRL ALT 1

Boroondas Gupte added a comment - 29/Aug/08 09:22 AM
Attached patch as described by Opensource Obscure. Untested because I've got build problems (unrelated to this patch).
Patch is against revision 1122 of http://svn.secondlife.com/svn/linden/trunk

Nefertiti Nefarious added a comment - 29/Aug/08 10:21 AM

Editing and compiling source code to make Opensource Obscure's "trivial change" is not trivial for this Linux user. I'm using Ubuntu, not Gentoo!

The core of the problem is that hard-coded function keys should be avoided when you are trying to make an OS-agnostic, global application.


Boroondas Gupte added a comment - 30/Aug/08 05:05 AM
Nefertiti, that's why the long term solution to this will hopefully be VWR-2896 (vote it up!)
I guess Opensource's use of the term "trivial" was referring to the small impact his change has on the source*), not how easy or difficult the build process is. Building SL on Gentoo isn't any easier than on Ubuntu, by the way.

*) Exchanging a single constant with a single literal – as opposed to VWR-2896, with patches adding more than 3000 lines in total.


Rob Linden added a comment - 04/Sep/08 09:17 AM
We're debating what the right way of doing this is. We really would like to avoid ctrl-alt-1 if at all possible, since we're afraid using that key combo may cause problems with i18n character entry. Can someone float this on the sl-ux mailing list?
https://lists.secondlife.com/cgi-bin/mailman/listinfo/sl-ux

Khyota Wulluf added a comment - 14/Oct/08 06:17 PM
Ctrl Alt 1 conflicts in Icewm, lightweight window manager and handy for video capture. Attaching a patch that changes the Ctrl Alt F* series to Ctrl Shift F*. No conflicts found in KDE or Icewm for these. Other DE's and WM"s need to be tested as well as Windows and Mac.

Henri Beauchamp added a comment - 24/Oct/08 07:40 AM
"Reload personal setting overrides" was already using CTRL SHIFT F2, so I changed it to CTRL SHIFT F10 in my patch (see the slviewer-0-v12160-LinuxShortcuts.patch.bz2 attached file).

Khyota Wulluf added a comment - 24/Oct/08 03:13 PM
Ok sorry i really thought that series was clean. But i hope changing that little stray one wouldnt hurt.

Khyota Wulluf added a comment - 30/Oct/08 09:47 AM
Ok, ive been doing some work on these shortcut issues, i found a couple things.

Any Ctrl ALT combination is already used by X or some window managers, also true on mac and was only reported there. VWR-9473
ALT Shift Fn shortcuts have window manager conflicts too.
Ctrl Shift n is already used by some things in SL.
The = key does not register with any combination, at least in linux.

The only things left are Ctrl Shift Fn and Alt Shift n. Perfect to wipe out both these issues.

So i propose these changes.

Features menu options move to Ctrl Shift Fn.
Move that stray Reload pesonal settings overrides one to Ctrl Shift F12 (add a 1 to keep it simple and still stray )
Move Types menu options to Alt Shift n.
Move Particles to `.

As for the weird Particles one the = does not toggle it for some reason, i moved it to ` as a temporary solution. There probably isn't a best way to do this but someone has to make a decision, and some of these items probably should be moved around.

Posting this on VWR-9966, VWR-2085 VWR-9473 and Attaching a master patch.


Opensource Obscure added a comment - 20/Mar/09 06:05 AM
> As for the weird Particles one the = does not toggle it for some reason,
> i moved it to ` as a temporary solution.

note that ` is not available on some keyboard layouts as a single-stroke key - you have to press Alt-Gr ' to print that character.


Khyota Wulluf added a comment - 20/Mar/09 03:22 PM
Hopefully a someone has corrected the faulty = in some internal branch by now.

Baloo Uriza added a comment - 24/Apr/09 02:00 AM
If you are watching this bug, please also consider voting for VWR-1177.

Talia Tokugawa added a comment - 10/May/09 10:16 PM
Okies... not so much a fix and a tip/workaround...
The hidden interface is still usable while it's hidden... soo lowtech solution here... get a marker pen... mark the edge of your monitor... tear of the features menu that contains the interface hide option and move it to where the mark is. You now have an area of your sl screen that is marked as a place to hide/unhide the interface.

Nefertiti Nefarious added a comment - 11/May/09 05:59 PM
Talia -
Your kludge brings to mind jokes about white-out on the screens, but it works! Thanks for the lowest of the low-tech patches.

Opensource Obscure added a comment - 12/May/09 06:41 AM
It also appears to me that CTRL SHIFT S (shortcut for Snapshots) makes UI re-appear when hidden. This could help sometimes.

Rob Linden added a comment - 12/May/09 05:51 PM
This patch was nominated for inclusion in the sldev viewer by Opensource Obscure. The problem is that there's three different patches here, and it's not clear which ones are up for consideration, or which key combo will be used.

Question for OO: which patch file are you recommending, and what key combo does it implement?


Opensource Obscure added a comment - 12/May/09 06:33 PM
I think the right patch would be http://jira.secondlife.com/secure/attachment/20142/shortcutfix.patch - see comment by Khyota Wulluf on 30/Oct/08 for details about key combos. Right now I can't apply it against http-texture recent sources, though.

Soft Linden added a comment - 12/May/09 06:35 PM
Given that this is already committed to maint-viewer-14, the happier solution would be getting that merged into trunk and rebranching http-texture from trunk/. We're doing an awful lot of cherry picking, and it's going to make for a difficult merge later on.

Merov Linden added a comment - 28/May/09 01:34 PM
We're not going to branch from trunk for snowglobe before we get out a first release so, the choices are:
1- we live with that bug in that first snowglobe release.
2- we fix it. I can see creating a patch for snowglobe from OO "shortcutfix.patch" mentioned here above.

I'd be worried having people use snowglobe for machinima production (too unstable...) so I'm voting "1" here. I'm willing to be overruled though by a popular vote and do a patch, even if it makes merges a pain as mentioned by Soft (and since I do them on snowglobe, I know what I'm taking about... )


Opensource Obscure added a comment - 28/May/09 02:39 PM
I'm ok with 1 - This affects a small number of users, and I don't want to add merge pain

The real point is fixing it in the official viewer - right now I'm not sure about what exactly maint-viewer-14 is, but I hope it means "fixed in the next release cycle".


Satomi Ahn added a comment - 29/May/09 07:59 AM
Oh, there is a big issue with this patch: some keyboards like AZERTY keyboards (France, Belgium, ... ) and in some others don't have numbers in direct access.
Shortcuts in Alt/Shift/Control n won't be usable on those keyboards.

Being able to map a shortcut to a physical keycode rather than on the character the keyboard driver says is printed on the key, would be the only universal fix (is it even possible?).