• All submissions to this site are governed by Second Life Project Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.
Issue Details (XML | Word | Printable)

Key: VWR-1852
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Jacek Antonelli
Reporter: Jacek Antonelli
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
1. Second Life Viewer - VWR

Edit Manipulators have Wrong Orientation with Local Ruler Mode on Linked Objects

Created: 21/Jul/07 06:06 PM   Updated: 15/Dec/08 09:11 PM
Return to search
Component/s: Building (in-world), User Interface
Affects Version/s: 1.18.0
Fix Version/s: 1.19.1 Release Candidate

File Attachments: 1. Text File VWR-1852_local_axes.patch.txt (0.5 kB)
2. Text File VWR-1852_local_axes2.patch.txt (0.5 kB)

Image Attachments:

1. wrong_local_axis.jpg
(70 kB)
Issue Links:
Duplicate
 
Relates
 

Linden Lab Issue ID: DEV-2276
Patch attached: Patch attached


 Description  « Hide
Repro:
  • Open Build mode, Edit mode (Ctrl-3), and set the Ruler mode to "Local".
  • Rez two prims.
  • Rotate the second prim to be different from the first.
  • With the second prim selected, observe that the manipulator arrows are oriented to the second prim.
  • Close and re-open Build mode to clear the object selection.
  • Select the second prim.
  • Hold shift and select the first prim. Both prims are now selected.
  • Link the two prims to form one object.
  • Observe that the manipulator arrows are oriented the same as the root prim (the first prim, unrotated).
  • Close and re-open Build mode to clear the object selection.
  • Re-select the linked prims.
  • Expected: the manipulator arrows should be oriented to the root prim.
    = Observed: the maniputalor arrows are oriented to the NON-root prim.

This works for any number of prims in a linkset. The orientation of the edit manipulators will be taken from whichever prim was selected second-to-last before linking. (I think that corresponds to the first non-root prim in the linkset, but I may be wrong.)



 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
WarKirby Magojiro added a comment - 21/Jul/07 09:41 PM
I disagree. The way it works, is the behaviour I always expected from it since the start.

Not only that, it is useful, this way. Your proposed solution would break a valuable build tool for the sake of correctness in naming terms. That is unacceptable.

A better idea, would be to have a NEW ruler mode, aligned to the root.


Lex Neva added a comment - 22/Jul/07 10:02 AM
Are you sure that's the way it chooses which axes to align with, Jacek? I was under the impression that the axes didn't actually match any of my prims... perhaps I wasn't paying close enough attention. Either way, I'm not sure I agree with warkirby. The current local axes are essentially useless for linked sets (or unlinked selections), and this is NOT the way it used to work. It used to align the local axes with the root prim, I believe.

Warkirby, can you give an example of a building sequence that makes use of the local axes as they are now, that would break if this is changed to meet Jacek's expectations?


Jacek Antonelli added a comment - 22/Jul/07 01:30 PM
@Lex: It definitely matches the rotation (but not position) of one of the prims, but I was not quite correct in how it chooses which prim to match. I went back to confirm that it always worked the way I described, but found that sometimes it acted differently. After doing some tests with several prims (5), I've figured out a description which always applies:

The axes align themselves to the OLDEST NON-ROOT PRIM in the linkset. ("Oldest" is measured by creation date of the prim, which you can check with the Inspect floater.) I can produce screenshots documenting this, if needed.

This is a very strange way for it to choose which prim to use. I doubt anyone could argue that this behavior is either "expected" or "useful". Any "valuable build tool" which takes advantage of this quirk in the Local ruler mode UI would be more robust using the Reference ruler mode, anyway. (Setting aside the slight inconvenience that "Use selection for grid" is broken when selecting a linked part – but that's a different bug entirely.)


lindenrobot made changes - 16/Oct/07 11:02 AM
Field Original Value New Value
Linden Lab Issue ID DEV-2276
Torley Linden added a comment - 16/Oct/07 11:03 AM
Importing from our UI triage for further investigation... thanks for all the details, Jacek...

Jacek Antonelli added a comment - 25/Oct/07 12:12 AM
Attached a patch to fix this issue. The problem turned out to be that the rotation of the manipulators was being taken from the rotation of the selection bounding box for the object, which was in turn being taken from the rotation of the first object that it looked at when creating that bounding box (which, it seems, is the oldest prim in the link set). Phew, that's a mouthful.

Anyway, I fixed it by initializing the bounding box from the root prim first. Now the move, rotate, and scale manipulators are oriented with the root prim, as they ought to be.

Note that the bounding box I'm talking about is not related to the physics simulation; it's part of the selection manager, and as far as I can tell without seeing the server source, is client-side only.


Jacek Antonelli made changes - 25/Oct/07 12:12 AM
Attachment VWR-1852_local_axes.patch.txt [ 12480 ]
Jacek Antonelli added a comment - 06/Nov/07 01:16 AM
Okay, I've discovered that the patch has a unwanted side effects when editing linked parts, and so is not ready to be applied. I'm working on an alternative patch to correct the side effects.

Jacek Antonelli made changes - 06/Nov/07 01:19 AM
Assignee Jacek Antonelli [ Jacek Antonelli ]
Jacek Antonelli made changes - 06/Nov/07 01:30 AM
Status Open [ 1 ] In Progress [ 3 ]
Jacek Antonelli added a comment - 09/Nov/07 09:13 PM
Attached a new patch, which should be applied instead of the other one.

I'm mostly satisfied now. The only annoyance I have is that the order the prims in a linkset are selected when Edit Linked Parts is turned on, means that the axes change. But, it's a minor annoyance, and can be worked-around by un-selecting and then re-selecting the root prim, if desired.


Jacek Antonelli made changes - 09/Nov/07 09:13 PM
Attachment VWR-1852_local_axes2.patch.txt [ 12680 ]
Jacek Antonelli made changes - 09/Nov/07 09:21 PM
Status In Progress [ 3 ] Open [ 1 ]
Jacek Antonelli added a comment - 17/Dec/07 08:51 AM
D'oh. I totally forgot to mark "Patch attached". My bad.

Jacek Antonelli made changes - 17/Dec/07 08:51 AM
Patch attached [Patch attached]
Rob Linden made changes - 22/Dec/07 01:34 AM
Workflow jira [ 14049 ] jira-2007-12-21 [ 22518 ]
Rob Linden made changes - 22/Dec/07 01:58 AM
Workflow jira [ 22518 ] jira-2007-12-21 [ 23834 ]
Rob Linden made changes - 22/Dec/07 02:59 PM
Workflow jira-2007-12-21 [ 23834 ] jira-2007-12-22 [ 30550 ]
Rob Linden made changes - 22/Dec/07 03:21 PM
Workflow jira-2007-12-21 [ 30550 ] jira-2007-12-22 [ 32157 ]
Rob Linden made changes - 22/Dec/07 08:05 PM
Workflow jira-2007-12-22 [ 32157 ] jira-2007-12-22a [ 37445 ]
Rob Linden made changes - 22/Dec/07 08:27 PM
Workflow jira-2007-12-22 [ 37445 ] jira-2007-12-22a [ 38743 ]
Rob Linden made changes - 22/Dec/07 09:21 PM
Workflow jira-2007-12-22 [ 38743 ] jira-2007-12-22a [ 41358 ]
Rob Linden made changes - 22/Dec/07 09:42 PM
Workflow jira-2007-12-22 [ 41358 ] jira-2007-12-22a [ 42609 ]
McCabe Maxsted made changes - 05/Jan/08 06:51 AM
Link This issue is duplicated by SVC-998 [ SVC-998 ]
McCabe Maxsted made changes - 14/Feb/08 09:25 AM
Link This issue is related to by SVC-991 [ SVC-991 ]
Lex Neva added a comment - 20/Mar/08 11:29 AM
This is marked as fixed in 1.19.1 RC2

Jacek Antonelli added a comment - 20/Mar/08 01:22 PM
Confirmed fixed in 1.19.1 (2) RC. Yay!

Jacek Antonelli made changes - 20/Mar/08 01:22 PM
Status Open [ 1 ] Closed [ 6 ]
Fix Version/s 1.19.1 Release Candidate [ 10270 ]
Resolution Fixed [ 1 ]
Sue Linden made changes - 13/Nov/08 11:41 AM
Workflow jira-2007-12-22a [ 42609 ] jira-2008-11-14 [ 75453 ]
Sue Linden made changes - 13/Nov/08 06:39 PM
Workflow jira-2008-11-14 [ 75453 ] jira-2008-11-14a [ 133374 ]
Jacek Antonelli made changes - 15/Dec/08 09:11 PM
Link This issue is related to by VWR-11103 [ VWR-11103 ]