• All submissions to this site are governed by Second Life Project Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.
Issue Details (XML | Word | Printable)

Key: VWR-1826
Type: Sub-task Sub-task
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Unassigned
Reporter: Nicholaz Beresford
Votes: 3
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
1. Second Life Viewer - VWR
VWR-1825

Inventory double click: Landmarks -> Teleport

Created: 20/Jul/07 12:42 AM   Updated: 30/Nov/07 07:11 AM
Return to search
Component/s: User Interface
Affects Version/s: None
Fix Version/s: 1.18.5 Release Candidate

Linden Lab Issue ID: SL-49652


 Description  « Hide

With regard to my intro in the parent issue (see VWR-1825), I believe that a double click on a landmark should immediately and without extra dialog perform a teleportation.

The corresponding code piece for llfolderview.cpp would be quite simple:

void LLFolderViewItem::preview( void )
{
if (mListener)
{
if (mListener->getInventoryType() == LLInventoryType::IT_LANDMARK) { gFocusMgr.setKeyboardFocus(NULL, NULL); // focus back to main window, user will want to move with arrow keys mListener->performAction(NULL, &gInventory, "teleport"); }
else { mListener->previewItem(); }
}
}

 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
Nicholaz Beresford made changes - 20/Jul/07 12:43 AM
Field Original Value New Value
Description
With regard to my comment in the parent issue, I believe that a double click on a landmark should immediately and without extra dialog perform a teleportation.

The corresponding code piece for llfolderview.cpp would be quite simple:



void LLFolderViewItem::preview( void )
{
if (mListener)
{
if (mListener->getInventoryType() == LLInventoryType::IT_LANDMARK) {
gFocusMgr.setKeyboardFocus(NULL, NULL); // focus back to main window, user will want to move with arrow keys
mListener->performAction(NULL, &gInventory, "teleport");
}
else {
mListener->previewItem();
}
}
}
With regard to my intro in the parent issue (see VWR-1825), I believe that a double click on a landmark should immediately and without extra dialog perform a teleportation.

The corresponding code piece for llfolderview.cpp would be quite simple:



void LLFolderViewItem::preview( void )
{
if (mListener)
{
if (mListener->getInventoryType() == LLInventoryType::IT_LANDMARK) {
gFocusMgr.setKeyboardFocus(NULL, NULL); // focus back to main window, user will want to move with arrow keys
mListener->performAction(NULL, &gInventory, "teleport");
}
else {
mListener->previewItem();
}
}
}
lindenrobot made changes - 23/Jul/07 02:00 PM
Linden Lab Issue ID SL-49652
Sardonyx Linden made changes - 06/Aug/07 11:30 AM
Assignee Sardonyx Linden [ Sardonyx Linden ]
Coco Linden made changes - 09/Aug/07 05:10 PM
Assignee Sardonyx Linden [ Sardonyx Linden ] Coco Linden [ Coco Linden ]
[ Permlink | « Hide ]
Coco Linden added a comment - 09/Aug/07 05:31 PM
This was one of my earliest pet peeves as a resident.
I used the supplied patch but applied it to the handleDoubleClick method rather than in preview for a better semantic match. Thanks once again Nicholaz!

Coco Linden made changes - 09/Aug/07 05:31 PM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed Internally [ 7 ]
[ Permlink | « Hide ]
Nicholaz Beresford added a comment - 10/Aug/07 02:49 AM

Makes sense! Thanks Coco!

[ Permlink | « Hide ]
Milo Linden added a comment - 27/Aug/07 11:54 AM
Reopened as code has been backed out due to ui design discussions

Milo Linden made changes - 27/Aug/07 11:54 AM
Resolution Fixed Internally [ 7 ]
Status Resolved [ 5 ] Reopened [ 4 ]
[ Permlink | « Hide ]
Coco Linden added a comment - 28/Aug/07 02:38 PM
Here's what the backed-out implementation was for the record:

BOOL LLFolderViewItem::handleDoubleClick( S32 x, S32 y, MASK mask )
{
if (mListener->getInventoryType() == LLInventoryType::IT_LANDMARK)

{ gFocusMgr.setKeyboardFocus(NULL, NULL); // release focus to main window so user can move with arrow keys mListener->performAction(NULL, &gInventory, "teleport"); }

else

{ preview(); }

return TRUE;
}


[ Permlink | « Hide ]
Benjamin Linden added a comment - 29/Aug/07 04:33 PM
Apologies for the confusion on this; we should've closed this task and focused efforts on VWR-1825 (where there's further discussion around doubleclick patterns in the Viewer). Part of this was a result of the confusing way Pjira tasks get imported (without regard to nested relationships). But we also should've communicated more clearly that the design for this particular issue was still being discussed. Based on the outcome of VWR-1825, we'll make comprehensive changes to doubleclick behavior in Inventory.

[ Permlink | « Hide ]
Nicholaz Beresford added a comment - 30/Aug/07 05:45 AM

Thanks Coco and Ben for the feedback. Appreciated.

Nicholaz Beresford made changes - 03/Sep/07 03:18 AM
Patch attached [Patch attached]
Henri Beauchamp made changes - 19/Nov/07 11:06 AM
Status Reopened [ 4 ] Resolved [ 5 ]
Fix Version/s 1.18.5 Release Candidate [ 10200 ]
Resolution Fixed [ 1 ]
[ Permlink | « Hide ]
Nicholaz Beresford added a comment - 30/Nov/07 07:07 AM
as per ben's note I'm changing this to open again (from "fixed" which coco thought it was)

Nicholaz Beresford made changes - 30/Nov/07 07:07 AM
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]
Assignee Coco Linden [ Coco Linden ]
[ Permlink | « Hide ]
Nicholaz Beresford added a comment - 30/Nov/07 07:11 AM

Oh, it is fixed in 1.18.5 ... sorry for the confusion. Closing ...

Nicholaz Beresford made changes - 30/Nov/07 07:11 AM
Status Reopened [ 4 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Nicholaz Beresford made changes - 30/Nov/07 07:11 AM
Status Resolved [ 5 ] Closed [ 6 ]
Rob Linden made changes - 22/Dec/07 03:33 AM
Workflow jira [ 13987 ] jira-2007-12-21 [ 29367 ]
Rob Linden made changes - 22/Dec/07 04:06 PM
Workflow jira-2007-12-21 [ 29367 ] jira-2007-12-22 [ 36286 ]
Rob Linden made changes - 22/Dec/07 11:09 PM
Workflow jira-2007-12-22 [ 36286 ] jira-2007-12-22a [ 47466 ]
Sue Linden made changes - 13/Nov/08 11:41 AM
Workflow jira-2007-12-22a [ 47466 ] jira-2008-11-14 [ 75438 ]
Sue Linden made changes - 13/Nov/08 06:39 PM
Workflow jira-2008-11-14 [ 75438 ] jira-2008-11-14a [ 133330 ]

Powered by Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.2-#335) - Bug/feature request - Atlassian news - Contact Administrators