[#VWR-1826] Inventory double click: Landmarks -> Teleport

1. Second Life Viewer - VWR

VWR-1825

Inventory double click: Landmarks -> Teleport

Created: 20/Jul/07 12:42 AM Updated: 30/Nov/07 07:11 AM

Component/s:

User Interface

Affects Version/s:

None

Fix Version/s:

1.18.5 Release Candidate

Linden Lab Issue ID:

SL-49652

Description

« Hide

With regard to my intro in the parent issue (see ~~VWR-1825~~), I believe that a double click on a landmark should immediately and without extra dialog perform a teleportation.

The corresponding code piece for llfolderview.cpp would be quite simple:

void LLFolderViewItem::preview( void )
{
if (mListener)
{
if (mListener->getInventoryType() == LLInventoryType::IT_LANDMARK) {
gFocusMgr.setKeyboardFocus(NULL, NULL); // focus back to main window, user will want to move with arrow keys
mListener->performAction(NULL, &gInventory, "teleport");
}
else {
mListener->previewItem();
}
}
}

All

Comments

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Coco Linden - 09/Aug/07 05:31 PM

This was one of my earliest pet peeves as a resident.
I used the supplied patch but applied it to the handleDoubleClick method rather than in preview for a better semantic match. Thanks once again Nicholaz!

[ Permlink | « Hide ]

Nicholaz Beresford - 10/Aug/07 02:49 AM

Makes sense! Thanks Coco!

[ Permlink | « Hide ]

Milo Linden - 27/Aug/07 11:54 AM

Reopened as code has been backed out due to ui design discussions

[ Permlink | « Hide ]

Coco Linden - 28/Aug/07 02:38 PM

Here's what the backed-out implementation was for the record:

BOOL LLFolderViewItem::handleDoubleClick( S32 x, S32 y, MASK mask )
{
if (mListener->getInventoryType() == LLInventoryType::IT_LANDMARK)
{
gFocusMgr.setKeyboardFocus(NULL, NULL); // release focus to main window so user can move with arrow keys
mListener->performAction(NULL, &gInventory, "teleport");
}
else
{
preview();
}
return TRUE;
}

[ Permlink | « Hide ]

Benjamin Linden - 29/Aug/07 04:33 PM

Apologies for the confusion on this; we should've closed this task and focused efforts on ~~VWR-1825~~ (where there's further discussion around doubleclick patterns in the Viewer). Part of this was a result of the confusing way Pjira tasks get imported (without regard to nested relationships). But we also should've communicated more clearly that the design for this particular issue was still being discussed. Based on the outcome of ~~VWR-1825~~, we'll make comprehensive changes to doubleclick behavior in Inventory.

[ Permlink | « Hide ]

Nicholaz Beresford - 30/Aug/07 05:45 AM

Thanks Coco and Ben for the feedback. Appreciated.

[ Permlink | « Hide ]

Nicholaz Beresford - 30/Nov/07 07:07 AM

as per ben's note I'm changing this to open again (from "fixed" which coco thought it was)

[ Permlink | « Hide ]

Nicholaz Beresford - 30/Nov/07 07:11 AM

Oh, it is fixed in 1.18.5 ... sorry for the confusion. Closing ...