|
|
|
[
Permlink
| « Hide
]
McCabe Maxsted added a comment - 08/Jul/07 05:54 PM
Can you attach a screenshot? I'm curious what the difference looks like for you, as compared to one my friend took of me.
Okay, I finally got around to creating a video of this bug. It uses the XVid codec which you can download at http://www.xvid.org
 . Here's what you'll see:
You're looking at my av, Lex Neva. This video is actually taken from the client of my alt account, but that av is off-frame and has its camera focused on Lex Neva. I start video capturing. I select some prims in edit mode, with "show selection beam" on, to demonstrate how the selection beam SHOULD look. Then I turn "show selection beam" off on Lex Neva's client about halfway through the movie. On Lex Neva's client (not shown), the selection beam is invisible. On my alt account, you'll see an almost immediate change in teh selection beam to a weird blotchy set of circles. It appears that the beam particles are being drawn over each other repeatedly. I select other objects to show how the selection beam seems to leave trails. This effect is amplified if I walk while I have something selected: note the fan of selection beams that are left behind. This bug has been around since "Show selection beam" was introduced, months ago. It's a really strange bug, since "show selection beam", in theory, only affects MY view of my selection beam, and this bug seems to affect everyone else's view of my beam. I can only think that somehow my client sends a lot of information about how to render the selection beam, and this information is not being sent when the beam is hidden. If you look at the stats bar and watch Packets Out, you normally see 10-15 packets/sec going out. When you disable selection beam, packet output suddenly jumps to around 150 p/s (while you have something selected of course). So the viewer definitely does something very weird.
Here's the simple patch. Haven't tested it yet with another person but the packet rate is fixed after this which indicates I probably nailed it. Most likely what it does without the patch is an endless kill/create cycle on the stream. I only spend a few minutes on this so I haven't researched it in full.
Thanks, Blakar. I think maybe some more work ought to be done on that code... I'm not up on LL's coding standards, but I think some parentheses are needed in that conditional to ensure that the &&s and ||s are given the precedence intended by the author.
This bug has been around for as long as I've been in SL.. and here's what I THINK may be happening (from a non programmer's perspective)
At some point in the past, The Option "Tools > X Show Selection Beam" used to read "Tools > X Show Selection Beams" and a second option existed that read "Tools > _ Hide My Selection Beam" 2 settings, not one. "Hide/Show all selection beams I can see" and "hide my selection beam from others". It is my hypothesis that these were once TWO functions... and were combined by a well meaning programmer looking to clean up the menus. What happened, it seems (to the casual user) is that the setting got messed up some how in the process of combining them, perhaps because one was "true to show" and one was "false to show". So that [FALSE] Show Selection Beam hid all "selection beam particles for the user" but rather than also "hiding the user's selection beam from others" it "doubled" the beam's intensity in some fashion, as viewed by others. It's currently "broken" function is rather odd. I would expect that this "unified" function would serve to both "hide all those damn selection beams" and at the same time "make my beam invisible to others". Instead, it "hides all the beams from me" and makes my beam extra strong? Lex,
I'm not touching the parentheses simply because there were none in the first place. As such for QA it's easier if there are no cosmetic changes. The patch now only changes what should be really changed. Winter, Winter, that's an interesting theory, but I'm pretty sure that's not how it happened. I remember when we got "Show Selection Beam", and there wasn't any other option having to do with selection beams previous to that. As far as I know, there's no way at all to prevent your selection beam from being shown to others... aside from hacking the client source.
Fixed internally. Thanks for the report and patch! I didn't use the patch in the end (it had some issues), but I'll attach the diff I did use.
Changed status to "Fixed" – I'm going through the Issue Tracker and updating issues that've been publicly fixed! |
|||||||||||||||||||||||||||||||||||||||||||||||||||
 |
|
Bug
Closed
Low
disabling "Show Selection Beam" makes beam render incorrectly for others
