• All submissions to this site are governed by Second Life Project Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.
MAINTENANCE ANNOUNCEMENT - JIRA will undergo maintenance starting 1:00am PDT through 3:00am on Saturday 2010.03.20. Please do not enter issues during this time as the system maybe restarted.
Issue Details (XML | Word | Printable)

Key: VWR-1471
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Low Low
Assignee: kelly linden
Reporter: Nicholaz Beresford
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
1. Second Life Viewer - VWR

Inspect (Pie menu > More > More > Inspect) shows nothing on first use when "only select own objects" is enabled

Created: 01/Jul/07 02:16 PM   Updated: 10/Jun/08 09:38 AM
Component/s: None
Affects Version/s: 1.17.0.x, 1.17.1
Fix Version/s: 1.18.1.2

Time Tracking:
Not Specified

File Attachments: 1. Text File 1471_inspect.patch (1 kB)
2. Text File inspectShow-before-after.txt (1.0 kB)

Issue Links:
Relates

Source Version: 1.17.2
Linden Lab Issue ID: SL-48165
Patch attached: Patch attached


 Description  « Hide

First time after login the Inspect function does not seem to work.

Repro:

  • Login
  • Tools-Menu, activate "only select own objects"
  • Right-click any object not owned by you (this is what Inspect is mostly used to find out)
  • More, More, Inspect

Observe:
List remains empty

Correct:
List should show owner/creator etc.

Subsequent uses of the function seem to work.



 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Nicholaz Beresford added a comment - 01/Jul/07 04:56 PM

This seems to be a tricky one ... more details:

It only happens when the tool menu is set to only select own objects.

The pie menu does a temporary selection which highlights objects regardless of the setting.

When the inspect window opens first time, it takes the focus. The pie menu then clears the selection based on the setting, i.e. when "only own objects" is on, the pie menu makes the selection go away and when the inspect window looks at the selection, nothing is there.

If anyone likes to work at this, let me know and I'll give you the tech details.


Nicholaz Beresford added a comment - 02/Jul/07 05:22 PM

Patch description:

The problem in 1.17.2 is that the pie menu (right click) allows to select items despite the "Only select own items" setting. However, when inspect opens, the pie menu loses focus and then does a valdate-select which only leaves valid selections, i.e. with "only select own" it deselects the content that was previously selected and for which the Inspect window was called.

The easiest way to work around it seems to be to use the gSelectMgr->setForceSelection function, which prevents the deselection when the pie menu loses focus. So it is just necessary that force-selection remains enabled until the Inspect window has it's focus and has it's tool in place.

I added a paramter to setForceSelection to return the previous state (this is probably not strictly necessary, setForceSelection(TRUE) and setForceSelection(FALSE) would do also, but I like to play safe here).

I also rearranged the code for LLFloaterInspect::show() a bit for more clarity, which unfortunately makes the patch itself less clear. So I'm also attaching a file with the full function before and after the change (it's just about 12 lines) and should make the change sufficiently clear.


kelly linden added a comment - 11/Jul/07 12:44 PM
Fixed internally in the maintenance branch.

Dzonatas Sol added a comment - 14/Jul/07 08:32 AM
A patch or contribution from this issue has been applied (and maybe modifed)
to the Open Source Viewer, 1.18.0.6.OS.1. Download it here to test it:
http://sourceforge.net/project/showfiles.php?group_id=191214

Nicholaz Beresford added a comment - 09/Aug/07 03:39 AM

Thanks Kelly