[#VWR-14475] Advanced->XUI->Load from XML is broken

1. Second Life Viewer - VWR

Advanced->XUI->Load from XML is broken

Created: 01/Jul/09 08:06 PM Updated: 30/Sep/09 06:44 PM

Component/s:

User Interface

Affects Version/s:

1.23

Fix Version/s:

None

Time Tracking:

Not Specified

File Attachments:

LoadXUI.patchfile (1 kB)

Environment:

MS Windows XP

Issue Links:

Relates

This issue is related to by:

~~VWR-15310~~ Advanced->XUI->Save to XML doesn't set proper XML tags

~~SNOW-259~~ Fix Advanced->XUI load and save to XML

VWR-10924 Magical scripted HUD/UI

Last Triaged:	10/Sep/09 10:13 AM
Linden Lab Issue ID:	DEV-34848
Patch attached:	Patch attached

Description

« Hide

Load from XML fails to load any floater because a prefix is added to the full path returned from the file picker. The checks in the code are in the wrong place.

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

lindenrobot added a comment - 02/Jul/09 10:13 AM

Automated note to patch contributor: if you haven't done so already, please make sure you have a contribution agreement on file and that your patch includes an edit to doc/contributions.txt properly crediting yourself for this patch. See https://wiki.secondlife.com/wiki/Submitting_code for more details.

[ Permlink | « Hide ]

Merov Linden added a comment - 30/Sep/09 02:27 PM

Patch review: +1. Built on Windows no problem though I didn't exercise that code in test. The fix is around opening xml files and seems perfectly safe.

[ Permlink | « Hide ]

lindenrobot added a comment - 30/Sep/09 06:44 PM

Revision 2814 by rob.linden on 2009-09-30 20:44:05 -0500 (Wed, 30 Sep 2009)

VWR-14475 - Fix for Advanced->XUI->Load from XML

Files affected:
U projects/2009/snowglobe/trunk/doc/contributions.txt
U projects/2009/snowglobe/trunk/indra/llui/lluictrlfactory.cpp