|
|
|
[
Permlink
| « Hide
]
Thraxis Epsilon added a comment - 28/Jun/07 03:33 PM
That bug would be my fault, I'll get a patch added to this issue soon to fix that problem.
This item is a bug resulting from the chat logging patch in
Bah, I liked this behavior! Any way to make it an option?
 (Adding a color option for incoming IMs, that is, like the LLOwnerSay option that was added.) I have a patch to fix this issue. It also includes a fix for
Thraxis, if possible, please submit future patches with the source path starting from "linden/"
(https://wiki.secondlife.com/wiki/Submitting_code  ) Attached corrected patch to follow code submission standard
Thraxis: I just had a comment on my blog regarding my viewer which has your patch applied: )) ... but the chat console, the opaque chat that you see at the bottom left when chat history is not displayed. I see chat just not IMs. It works in the standard viewer. (( I have not checked it yet (am still at work), but can you please check if your patch doesn't break display of IM's in the half transparent chat view area? I guess I'll have to call this one not good. In Linden 1.17.2 IM showed in chat at least when "IM to History" was off. With this patch it appears that IM never shows in Chat. Umm, I guess I'm completely confused. Please disregard my last two previous comments. I need to test this in depth, but I think it is okay and I was just suffering from brain congestion. I'm sorry for the false alert, the patch does work ok in relation to chat console and chat history. A patch or contribution from this issue has been applied (and maybe modifed)
to the Open Source Viewer, 1.18.0.6.OS.1. Download it here to test it: http://sourceforge.net/project/showfiles.php?group_id=191214 This patch will probably require discussion in the UI triage, regarding chat console (the transparent termporary chat window) and chat history. This patch allows or suppresses IMs in chat console and chat history both depending on the "Show IM in chat history" prefs setting. Thraxis says he did that in regard to I looked into the details of the patch. As far as I can tell, the 2nd hunk is the one which changes the IM to Chat console behavior. I think this change requires some thorough discussion or addressing the real problems. that is the need for an option to suppress Group IM alone, because I do think people are happy with the behavior regarding IM. If not, I'd vote for two options ("IM to Chat history" and "IM to Chat console"). I'm attaching "1420_im_unreadable.patch" which is basically Thraxis' patch without the 2nd hunk. It only addresses the problem that IM's are unreadable in Chat History and nothing else. Bottome line: Please just fix what's broken and thoroughly discuss UI changes like this. Thanks for working on this guys. Thraxis, can you add a screenshot of what this patch looks like? Nicholaz, can you add this to the UI bug triage agenda for next week? Thanks.
Hello Thraxis and Nicholaz,
I tried this out and there were two things I noticed. 1) I'm not sure the System color is the best one to use for this. I think it may be worth making a new color; not necessarily in the UI, but in the XML for sure. I asked BenGlenn and he seems to think that's reasonable. 2) What about IM? Poor IM, sitting all alone and in the cold, still has LLColor4::grey chat history. It would be good to be consistent and bring IM some updated color too. Fix that (and naturally keep the groupchat IM features out for another bug) and I think it'll make it in. This is worth bringing up at the UI triage as well. Thanks for your efforts! And it's looking like the Voice changes are going to be pushed into release soon, those changes will probably take care of 2) but may change all else otherwise. Keep an eye out for those changes.
My 1420 patch basically restores the behavior as before (IM's appearing in the same color in history as normal chat and as before). But btw, since you mention it, I noticed today that in the voice viewer the "[person] is typing ..." appears in bright cyan rather than halfbright gray as before. I think the "is typing..." message is of lesser relevance and low-lighting would be a better choice than highlighting. Voice changes should be out shortly.
Maybe the idea with the gray text was not bad, just that it was too dark. But it's a minor issue, so if it is considered fixed, you can leave it at that. Perhaps the – End of Log – should appear in a different color.... maybe grey, maybe cyan, hard to decide.
Damn it, it is still in Windlight too. Can't you apply that fixes here?
This issue was resolved as "Needs More Info" during our batch cleanup because it was set as affecting First Look: WindLight. On the Issue Tracker, we've noticed many duplicate issues and issues that lacked actionable info or were already fixed.
WindLight recently "graduated" from a "First Look" technology preview to Release Candidate status – nearing inclusion in the main viewer with your help! So, "First Look: WindLight" does not exist anymore. More info and how to download the RC viewer: http://blog.secondlife.com/2008/03/06/new-release-candidate-viewer-1191-rc0-available/ If you've verified that this issue is still a problem in the newest Release Candidate, here's what to do next: (1) Search the Issue Tracker to make sure it isn't a duplicate of an existing issue we know about. If it is, link it as a duplicate using the "Link this issue..." link on the left. You can learn more about searching by watching this video tutorial: http://www.youtube.com/watch?v=SAlXK5hSVMc (2) Reopen the issue and BE SURE to update the "Affects Version/s" to the correct one, most likely ONLY "1.19.1 Release Candidate". However, if this bug affects the main viewer (1.19.0 as of this writing), then DO NOT set it to an RC version. Only set it to 1.19.0 instead. Be as specific with versions as possible – there's generally no need to set multiple versions, as it tends to dilute and confuse where a bug originated. (3) Add any other relevant details that would help us fix it. We can't stress the importance of a "solid repro" enough – a reliable series of steps to make a bug happen reliably. (4) Come and attend our inworld bug triages, where you can meet with Linden Lab employees to look at, verify, and expedite bugs for fixing. More info @ http://wiki.secondlife.com/wiki/Bug_triage Thank-you for helping us improve Second Life! Well here is more info, 1.19.1 RC4 of the new viewer still has that. Guess it will never change. All colors for chat are changeable, only this not. Why?
Forgot to change title for new version
WEll it is still the same, read my comments before.
I'm with Celierra, I liked this behavior.
Yes, me too, it would be nice to have an option for that to change the color maybe, even if it is a debug option.
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 |
|
Bug
Reopened
Normal
IM in chat history is rendered nearly unreadbale in 1.19.1 RC4
