History | Log In     View a printable version of the current page.  
  • All submissions to this site are governed by Second Life Project Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you've read, understood, and agreed to those terms.
Issue Details (XML | Word | Printable)

Key: VWR-1230
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Unassigned
Reporter: Coyote Pace
Votes: 10
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
1. Second Life Viewer - VWR

Text highlighting in Chat History window is cancelled when history scrolls

Created: 14/Jun/07 11:01 AM   Updated: 08/Nov/07 03:02 PM
Component/s: Chat/IM, User Interface
Affects Version/s: 1.16.0.x, 1.17.0.x
Fix Version/s: 1.18.3 Release Candidate

File Attachments: 1. Text File 1230_selection_in_chat_history.patch (1 kb)

Environment: Any
Issue Links:
Duplicate
 

Linden Lab Issue ID: SL-25498
Patch attached: Patch attached


 Description  « Hide
It is possible to copy text from the Chat History window by highlighting it with a click-swipe mouse motion and then Ctrl+C keystroke. This is obviously handy for transferring text within and out of the SL viewer. However, if the text of interest is highlighted -- or in the process of being highlighted -- while another Chat line appears, the highlighting is cancelled entirely. This causes much cursing and fumbling, especially on a laptop with a touchpad. The problem is obviously more common in a very active chat environment.

It would be preferable for text highlighting to be maintained as the Chat History window scrolls, including highlighting in process. This is consistent with other Windows applications where text field scrolling is triggered externally (not by in-window user clicking or typing, that is). Can't speak to the Mac or Linux practices on this.

 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
Celierra Darling - 14/Jun/07 11:34 AM
An alternate method of fixing this would be to just copy the text immediately upon highlighting it. I can't think of any other reason to highlight the text (other than just to highlight it)

Lex Neva - 15/Jun/07 09:01 AM
I absolutely HATE this bug. I'm raising the priority... this is more than just a cosmetic bug.

Celierra Darling - 15/Jun/07 09:53 AM
Oops - my suggestion doesn't take care of the case where something is in the process of being highlighted.

Aimee Congrejo - 15/Jun/07 11:17 AM
The bug is also there on Mac. ^^;

Lex Neva - 16/Jun/07 09:43 AM
And Linux!

Celierra Darling - 16/Jun/07 01:42 PM
Changed environment to 'any'...

Torley Linden - 18/Jun/07 09:49 AM
Older pain that's been around awhile, I'll link it up.

Coyote Pace - 19/Jun/07 06:30 AM
[Celierra: "An alternate method of fixing this would be to just copy the text immediately upon highlighting it."] Indeed, but it seems inevitable that the darn window scrolls JUST as I'm about to Ctrl+C ! In addition to the 'in the process of...' eventuality that you noted.

Celierra Darling - 19/Jun/07 10:18 PM
I didn't mean manually copy, I meant automatically upon finishing highlighting the text.

Daedalus Young - 06/Jul/07 04:08 PM
Workaround:
Scroll the history window up a bit, then highlight the text.

Elbereth Witte - 07/Jul/07 01:00 PM
That workaround doesn't seem to work for me as far as I remember.

The highlight failure seems to strike when stuff is added to the window, regardless of visibility or resultant scrolling, I think.

A Linuxish copy-on-highlight feature would be absolutely awesome, though that still doesn't "fix" the bug, since highlighting what you want can/does take time.

Daedalus Young - 19/Jul/07 03:52 PM
Ah, I see what you mean. When new text is entered, but window does not scroll, the highlighting indeed stops.

Nicholaz Beresford - 19/Jul/07 10:46 PM

I'll give it a whirl.

Nicholaz Beresford - 20/Jul/07 06:32 AM

There are currently two issues:
- when the chat history (technically a texteditor) was scrolled to the bottom, a cold (finished) selection was cleared/not maintained
- a hot selection was always interrupted (cleared when scrolled to end or selection ended but remained when window was not scrolled to bottom)

Patch Description:
- when scrolled to end, a selection is maintained (source added part inside "if (was_scrolled)" )
- when a selection is hot, it will not be scrolled (was scrolled && !was_selecting) and the part which restores selection also restores the hot/cold state


Test Cases (did work here):
Observe behavior when new chat arrives and
- window scrolled to end and selection cold
- window scrolled to end and selection hot
- window scrolled back somewhere and selection cold
- window scrolled back somewhere and selection hot


Nicholaz Beresford - 20/Jul/07 06:34 AM

Extra patch note: Hunk will be off by about 15 lines ... I have removed two hunks of personal changes from the diff

Yuo Rang - 22/Jul/07 06:15 AM
Excellent a patch already, I wanted to add this bug but found this thread via search.

This problem is so annoying attending tutorials and trying to capture the class notes, I have to get up and fly away from everyone just to be able to select the relevant text so I can CTL-C it. Either that or wait till I'm alone, but that risks losing the chat buffer in a crash.

Lets hope Nicz patch is scooped up for inclusion soon. Good job Nicholaz.

Nicholaz Beresford - 22/Jul/07 11:27 AM

Yuo,

you can test that patch in my viewer already. http://nicholaz-beresford.blogspot.com/

Wouldn't hurt if someone tested it in real life under heavy condition before it is included.

Coco Linden - 27/Jul/07 06:06 PM
Patch applied. Thanks Nicholaz!

Torley Linden - 29/Aug/07 04:14 PM
FIXED in 1.18.3 Release Candidate viewer, an optional download. More info about what this means:

     » http://blog.secondlife.com/2007/08/29/new-update-process-introducing-release-candidate-viewers

Coyote Pace - 17/Sep/07 03:32 PM
The fix works a treat in 1.18.3 Release Candidate viewer! Thanks Nicholaz, and Linden vetting team!

Coyote Pace - 03/Oct/07 08:07 AM
The fix works perfectly well in the now-released version of the viewer too. Thanks Nicholaz! Closing this out.

Torley Linden - 08/Nov/07 03:02 PM
Just wanted to say thanks for checking on your own issue and marking resolution, Coyote! :)