[#VWR-113] bad getMetadata return code

1. Second Life Viewer - VWR

bad getMetadata return code

Created: 08/Feb/07 06:26 PM Updated: 07/Dec/08 08:22 PM

Component/s:

Graphics, Performance

Affects Version/s:

Source code

Fix Version/s:

1.13.4.x

Time Tracking:

Not Specified

Environment:

Debian Linux, x86_64, AMD x2 64bit, OpenJPEG, ATI Radeon Xpress 1100

Issue Links:

Duplicate

This issue duplicates:

~~VWR-123~~ OpenJPEG meta decode, Second Life patches

Source Version:	FL-1.13.3.57679
Linden Lab Issue ID:	DEV-3764
Patch attached:	Patch attached

Description

« Hide

patch against slviewer-src-FL-1.13.3.57679.tar.gz

LLImageJ2COJ::getMetadata returns an integer, 0 fail, 1 succeed but both data paths return 1 I guess that means it never figures out that the decode fails.

If the image decode failed, return false not true. It helps to toss out invalid images,
[ERROR] tcd_decode: incomplete bistream

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

SpacedOut Frye added a comment - 09/Mar/07 05:27 PM

~~VWR-123~~ fixes this issue in addition to others.

[ Permlink | « Hide ]

Tofu Linden added a comment - 16/Mar/07 04:50 AM

Fixed by ~~VWR-123~~ landing.

[ Permlink | « Hide ]

Rob Linden added a comment - 07/Dec/08 08:22 PM

Changing resolution to make patch accounting easier.