[#VWR-11103] Regression: VWR-1852 - Local ruler mode aligned incorrectly for linked objects

1. Second Life Viewer - VWR

Regression: VWR-1852 - Local ruler mode aligned incorrectly for linked objects

Created: 15/Dec/08 09:09 PM Updated: Thursday 10:52 AM

Return to search

Component/s:

Building (in-world), User Interface

Affects Version/s:

1.20, 1.21, 1.22 Release Candidate, 1.23

Fix Version/s:

None

File Attachments:

VWR-1852-local-ruler-mode-alignment.patch.txt (0.6 kB)

Image Attachments:

1. toolbug1.jpg
(111 kB)

Issue Links:

Duplicate

This issue is original of duplicate:

SVC-998 Object Local Rotation Incorretly Aligned to Child Prim

~~VWR-14155~~ Prim Editor/Tool not using correct rotations in LOCAL rulermode

~~VWR-13416~~ The Center of Rotation changes location and orientation after linking a set of prims, then deselecting/reselection the linkset

Relates

This issue Relates to:

~~VWR-5807~~ Wild rotations of linkset while using the editor in Local Ruler Mode via CTRL key

~~VWR-1852~~ Edit Manipulators have Wrong Orientation with Local Ruler Mode on Linked Objects

This issue is related to by:

VWR-15912 Positions of prims changed by linking.

Last Triaged:	03/Sep/09 01:17 PM
Source Version:	1.21.6
Linden Lab Issue ID:	DEV-25323
Patch attached:	Patch attached

Description

« Hide

The fix for ~~VWR-1852~~ was reverted in the process of fixing ~~VWR-5807~~ (aka DEV-12570). Well, actually, the fix for ~~VWR-5807~~ was to revert the Linden fix for ~~VWR-1852~~, but one would have hoped that an alternative fix could have been found for ~~VWR-1852~~, instead of leaving it broken again.

The regression appeared in 1.20.7. The relevant code is this, from LLSelectMgr::getGrid in newview/llselectmgr.cpp lines 1042:1059:

LLSelectMgr::getGrid - newview/llselectmgr.cpp:1042:1059

if (mGridMode == GRID_MODE_LOCAL && mSelectedObjects->getObjectCount())
{
	//LLViewerObject* root = getSelectedParentObject(mSelectedObjects->getFirstObject());
	LLBBox bbox = mSavedSelectionBBox;
	mGridOrigin = mSavedSelectionBBox.getCenterAgent();
	mGridScale = mSavedSelectionBBox.getExtentLocal() * 0.5f;

	// DEV-12570 Just taking the saved selection box rotation prevents
	// wild rotations of linked sets while in local grid mode
	//if(mSelectedObjects->getObjectCount() < 2 || !root || root->mDrawable.isNull())
	{
		mGridRotation = mSavedSelectionBBox.getRotation();
	}
	/*else //set to the root object
	{
		mGridRotation = root->getRenderRotation();			
	}*/
}

All

Comments

Change History

Sort Order:

[ Permlink | « Hide ]

Jacek Antonelli added a comment - 15/Dec/08 10:08 PM

Attaching an updated version of my patch to ~~VWR-1852~~ (same change, new line numbers). It still applies, and it still fixes the issue. I've not encountered any side effects from it. I'm open to suggestions for improving it If the Linden who handled ~~VWR-1852~~ (DEV-2276) had some objection to using that patch.

[ Permlink | « Hide ]

Rynnan Riggles added a comment - 02/Feb/09 02:55 AM

I changed the priority of this issue, for me it's even more like a real show stopper. I do quite a bit of building and use local rulers a lot for aligning angled builds since this is the only feasible way of doing it.

As I'm unable to use the patch, I'd rather have that in the normal viewer. As of today, the problem persists in 1.22 (added that too).

[ Permlink | « Hide ]

Ephyu Reino added a comment - 22/May/09 01:53 PM

This issue is still here, and is rather annoying.

[ Permlink | « Hide ]

Harleen Gretzky added a comment - 03/Aug/09 04:48 PM

Repro from ~~VWR-14155~~:

I have found a weird bug in the Tools/Prim Editor when trying to use the tool to reposition a linked object in LOCAL mode.
The bug appears when trying to use the prim tool/editor to move an object where it has the root rotated to 45 degrees over the Z Axis AND when the root has linked child which are NOT in the same rotation as the root.

If I build a plywood wall and rotates it to 45 degrees over the Z Axis. Then selects the linked object and change the ruler mode to LOCAL and moves the linked object to follow the wall it will NOT do that.

To reproduce:

Create 3 boxes besides each other. Rotate the 2 outer boxes a little different than the middle box. Then link them with the middle box as root.
Then go into edit again and set rulermode to LOCAL and keep the entire object selected while you set Rotation Z to 45.
Now close the editor and edit the object again. Keep the rulermode in LOCAL...now notice the direction arrows are screwed not in correct rotations (angles).