• All submissions to this site are governed by Second Life Project Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.
Issue Details (XML | Word | Printable)

Key: VWR-11068
Type: Bug Bug
Status: Open Open
Priority: Normal Normal
Assignee: Merov Linden
Reporter: Mm Alder
Votes: 0
Watchers: 3
Operations

If you were logged in you would be able to see more operations.
1. Second Life Viewer - VWR

Fixes for bugs in the spillover menus

Created: 13/Dec/08 11:16 AM   Updated: Thursday 10:58 AM
Return to search
Component/s: User Interface
Affects Version/s: 1.22
Fix Version/s: None

File Attachments: 1. File 1.22.11_spillover.patchfile (0.8 kB)
2. File spillover.patchfile (0.9 kB)

Issue Links:
Relates
 

Last Triaged: 19/Nov/09 01:26 PM
Source Version: 1.21.6, 1.22.11
Linden Lab Issue ID: DEV-25324
Patch attached: Patch attached


 Description  « Hide
While working on VWR-6199 I discovered a few bugs in the code for the spillover menus. It is not a problem in the current viewer unless the window is made very short. To see the problem, reduce the window height until it is only about an inch tall, then click on the Advanced menu. The viewer will appear to hang, but it's really just thrashing about trying to compose the spillover menus.

The crux of the problem is that even after it determines that it needs a spillover, it continues to add menu items to the original menu. That menu is full, of course, so it cleans up the spillover menu, adds the item, then recreates the spillover, now with two items. If it requires more than one spillover menu to fit (as it does when the viewer window is shortened), then it really goes crazy cleaning up and recreating the spillover menus.

If you resize the window while the menu is open, you can shuffle the items in the menu as its constraints keep changing.

The patch fixes this problem as well as one in updateParent which doesn't seem to be causing any trouble at the moment, but which was problematic for VWR-6199. The spillover menu always has its parent set on creation, so branch menu items there were treated differently that those not in the spillover.



 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
Techwolf Lupindo added a comment - 30/Mar/09 03:45 PM
This patch will crash the client on startup if there is no or default settings file.

Mm Alder added a comment - 31/Mar/09 03:29 PM
Techwolf, are you applying it to 1.21? I know it needs to be changed for 1.22, but I haven't got around to it yet.

Techwolf Lupindo added a comment - 31/Mar/09 10:30 PM
1.22.11

Mm Alder added a comment - 03/May/09 05:23 PM - edited
In 1.22 the destructor for the branch menu item now deletes its menu, so the spillover branch item deletes the spillover menu. That fixes one of the bugs. This patch, 1.22.11_spillover.patchfile, fixes the other bugs, but doesn't have the menu delete that the patch for 1.21.6 did.

Alexa Linden added a comment - 03/Sep/09 10:52 AM
This would be good to bring up on sldev@ for possible inclusion in Snowglobe

Merov Linden added a comment - 19/Nov/09 10:58 AM
May need to be updated for Snowglobe trunk. Could you take a new peek Mm Alder?