• All submissions to this site are governed by Second Life Project Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.
Issue Details (XML | Word | Printable)

Key: VWR-10854
Type: New Feature New Feature
Status: Resolved Resolved
Resolution: Fixed
Priority: Normal Normal
Assignee: Soft Linden
Reporter: catherine pfeffer
Votes: 1
Watchers: 3
Operations

If you were logged in you would be able to see more operations.
1. Second Life Viewer - VWR

Honour "share with group" and "allow anyone to copy" for snapshots

Created: 02/Dec/08 02:46 PM   Updated: Thursday 10:48 AM
Return to search
Component/s: Permissions
Affects Version/s: Source code
Fix Version/s: Snowglobe test build

File Attachments: 1. Text File VWR-8624-fixes.patch (1 kB)

Environment: Not relevant
Issue Links:
Relates
 

Last Triaged: 03/Sep/09 10:38 AM
Linden Lab Issue ID: DEV-24745
Patch attached: Patch attached


 Description  « Hide
The patch attached to this issue addresses two separate concerns (I did not want to open 2 issues for such small things):

1) Issue VWR-8624 allows the users to choose a set of default permissions and will be implemented in upcoming 1.23 release of the viewer.

Strangely enough, the current implementation does not honour "share with group" and "allow anyone to copy" for the snapshots. This is inconsistent with upload of sounds, animations and textures where these flags are honoured.

Here is the conceptual view I'd like to share:
permissions at creation time = (user-chosen defaults) OR (minimal permissions)
In this view, minimal permissions for snapshots are just more permissive than for textures, sound and animations.

2) PERM_MOVE is not set in user-defined next owner permissions for uploaded things. If this is not done here, it's fixed later by "fair use" rules for permissions, but it's cleaner to have it set correctly from the very beginning. This patch does that too.



 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
catherine pfeffer made changes - 02/Dec/08 02:53 PM
Field Original Value New Value
Link This issue Relates to VWR-8624 [ VWR-8624 ]
catherine pfeffer made changes - 02/Dec/08 02:53 PM
Link This issue Relates to VWR-8049 [ VWR-8049 ]
Gellan Glenelg made changes - 02/Dec/08 03:43 PM
Patch attached [Patch attached]
catherine pfeffer made changes - 03/Dec/08 12:55 AM
Description Issue VWR-8624 allows the users to choose a set of default permissions and will be implemented in upcoming 1.23 release of the viewer.

Strangely enough, the current implementation does not honour "share with group" and "allow anyone to copy" for the snapshots. This is inconsistent with upload of sounds, animations and textures where these flags are honoured.

Here is the conceptual view I'd like to share:
     permissions at creation time = (user-chosen defaults) OR (minimal permissions)
For the snapshots, the minimal permissions are permissive PERM_ALL for next owner, PERM_NONE for group and PERM_NONE for everyone. This is comparable to default permissions for notecards and gestures created from within the inventory. But having a *minimal* permission of PERM_NONE for the group is no reason for not honouring "share with group" choice when it is set. And having a *minimal* permission of PERM_NONE for everyone is no reason for not honouring "allow everyone to copy" choice when it is set.

I'm attaching a patch addressing the problem.

This patch also fixes something else :

It sets systematically PERM_MOVE in user-defined next owner permissions for uploaded things. If this is not done here, it's fixed later by "fair use" rules for permissions, but it's cleaner to have it set correctly from the very beginning.

The patch attached to this issue addresses two separate concerns (I did not want to open 2 issues for such small things):

1) Issue VWR-8624 allows the users to choose a set of default permissions and will be implemented in upcoming 1.23 release of the viewer.

Strangely enough, the current implementation does not honour "share with group" and "allow anyone to copy" for the snapshots. This is inconsistent with upload of sounds, animations and textures where these flags are honoured.

Here is the conceptual view I'd like to share:
     permissions at creation time = (user-chosen defaults) OR (minimal permissions)
In this view, minimal permissions for snapshots are just more permissive than for textures, sound and animations.

2) PERM_MOVE is not set in user-defined next owner permissions for uploaded things. If this is not done here, it's fixed later by "fair use" rules for permissions, but it's cleaner to have it set correctly from the very beginning. This patch does that too.
catherine pfeffer made changes - 03/Dec/08 01:07 AM
Attachment VWR-8624-fixes.patch [ 20715 ]
catherine pfeffer made changes - 03/Dec/08 01:08 AM
Attachment VWR-8624-fixes.patch [ 20722 ]
Coco Linden made changes - 04/Dec/08 02:30 PM
Assignee Coco Linden [ Coco Linden ]
Coco Linden made changes - 04/Dec/08 02:33 PM
Linden Lab Issue ID DEV-24745
Soft Linden made changes - 11/Dec/08 08:36 AM
Last Triaged 11/Dec/08 10:38 AM
Rob Linden made changes - 26/Feb/09 01:39 PM
Last Triaged 11/Dec/08 10:38 AM 26/Feb/09 10:38 AM
Soft Linden made changes - 19/Mar/09 10:42 AM
Assignee Coco Linden [ Coco Linden ]
Soft Linden made changes - 21/May/09 10:47 AM
Assignee Soft Linden [ Soft Linden ]
Rob Linden made changes - 28/May/09 10:43 AM
Last Triaged 26/Feb/09 10:38 AM 28/May/09 10:38 AM
Soft Linden made changes - 03/Sep/09 10:47 AM
Assignee Soft Linden [ Soft Linden ]
Alexa Linden made changes - 03/Sep/09 10:47 AM
Last Triaged 28/May/09 10:38 AM 03/Sep/09 10:38 AM
Assignee Soft Linden [ Soft Linden ]
Merov Linden made changes - 19/Nov/09 10:48 AM
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s Snowglobe test build [ 10435 ]
Resolution Fixed [ 1 ]