• All submissions to this site are governed by Second Life Project Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.
Issue Details (XML | Word | Printable)

Key: VWR-10311
Type: New Feature New Feature
Status: Fix Pending Fix Pending
Priority: Normal Normal
Assignee: Merov Linden
Reporter: Mm Alder
Votes: 13
Watchers: 4
Operations

If you were logged in you would be able to see more operations.
1. Second Life Viewer - VWR

Enable LipSync by default

Created: 04/Nov/08 02:13 PM   Updated: 08/Nov/09 02:38 PM
Return to search
Component/s: Voice
Affects Version/s: 1.23
Fix Version/s: Snowglobe test build

File Attachments: 1. File lipsync.patchfile (0.5 kB)
2. Text File VWR-10311-LipSync.patch (5 kB)

Issue Links:
Relates

Last Triaged: 30/Apr/09 07:28 AM
Source Version: 1.21.6
Linden Lab Issue ID: DEV-25511
Patch attached: Patch attached
Linden Lab Internal Branch: Maint Viewer 20

Sub-Tasks  All   Open   
 Sub-Task Progress: 

 Description  « Hide
The lip sync babble loop has been available as an unenabled option for quite a while now without any reports of problems. How about moving it out of "beta" status and enabling it by default.

 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
Geneko Nemeth added a comment - 04/Nov/08 04:41 PM
I beg to differ.

The babbling only works on yourself, since there's no way to get separate audio data from the SL client.

Also, it doesn't analyze the audio energy for the time being.


Chalice Yao added a comment - 04/Nov/08 11:42 PM - edited
I'm all for enabling lipsync by default. I've been having it enabled for quite a while, and no problems at all have shown to me so far.

Also, I don't quite understand what you mean 'it only works for yourself'. If lipsync gets enabled, it shows facial motion for all voicers to yourself, if you mean that, yeah.

It looks good, and it is (in my experience) rather well synced with voice already, even if it misses taking energy into acconut, so I don't see the issue?


Aimee Trescothick added a comment - 06/Nov/08 02:52 PM
Votes

Have been using this for so long now I'd forgotten it's not on by default.


Mm Alder added a comment - 13/Dec/08 10:56 AM
The patch is trivial, but I figured the issue might get more attention if it had a patch attached.

Geneko Nemeth added a comment - 18/Dec/08 08:43 PM
Sorry, I'm mistaken.
From what I heard, if you try to analyze the voice data for lip sync, you cannot get accurate results for everyone other than yourself since Vivox returns mixed audio data.
But since the voice data is not analyzed and the animation is merely babbling, this does not matter.

Khyota Wulluf added a comment - 29/Dec/08 11:55 AM
I dont think were taking into consideration how many residents use prim heads, and therefore this would be quite a waste as we will never see the lips of these avatars. Setting this as default would waste CPU power.

Mm Alder added a comment - 04/Jan/09 01:35 PM
This takes no more CPU resources than making eyes blink. You would not be able to measure a difference with the Fast Timers. The prim heads themselves are a far worse CPU load.

Vector Hastings added a comment - 20/Apr/09 04:30 PM
I also see lipsynch as a appealing, distinctive, and stable addition to SL. The only furry downside I could imagine is if folks have attached parts of their heads to their lower jaw. That might be visible but I can also imagine it being appealing. And of course, there will be the option to turn it off.

Tofu Linden added a comment - 20/Apr/09 05:06 PM
The existing lipsync doesn't really move the actual jaw attachment point.

TigroSpottystripes Katsu added a comment - 20/Apr/09 05:14 PM
it doesn't?! 0.0

where is the jira entry complaining about that ? link pls? o.o


Frans Charming added a comment - 21/Apr/09 06:49 AM
I concur, does should be on by default.

Mm Alder added a comment - 21/Apr/09 08:44 AM
Tigro, I haven't looked at the attachment points, but I suspect that it is on an integral part of the head, not a separate bone that could be animated. Lip movement is done with morphs, not bones. If there is a jaw bone, I can look into animating that as well. If it's just an attachment point on the head, though, I'm not sure it can be manipulated for individual avatars. If anyone knows an animation expert, let me know.

As an aside, I'm also looking to see if the set of morphs could be expanded. This would allow built in morphs for furry shapes or whatever.

Mike


TigroSpottystripes Katsu added a comment - 21/Apr/09 02:26 PM
wow, really? I always assumed it did the movements in a similar way as those things that move prim jaws when typing ot voice gestures to move prim jaws (not the ones that just move the prims by script, the ones that are compatible with any prim jaw)

Celierra Darling added a comment - 27/Apr/09 03:22 PM
Perhaps there should be a little data collection to sanity check whether few enough regular or new users would mind this (as opposed to us more-frequent users)? I think this would be a silly thing on which to get an unexpected backlash.

Mm Alder added a comment - 28/Apr/09 08:25 AM
Celierra, that's what a Release Candidate is meant to do.

Tofu Linden added a comment - 28/Apr/09 11:36 AM
For the record - I'm for it.

Maggie Darwin added a comment - 28/Apr/09 12:56 PM
I'm for it too...however, I don't quite agree with Mm's thought that "a Release Candidate is meant to" "sanity check whether few enough regular or new users would mind this (as opposed to us more-frequent users)".

If that were true, I would think an RC would be a very poor tool for the job, considering how few "regular or new users" run the RCs. An RC can sanity-check an implementation for errors. But if the requirements are wrong, you may not find out until it's forced out to the general population.

All that said, I think it's time for it to be on by defult...voted.


Gordon Wendt added a comment - 29/Apr/09 05:07 AM - edited
Since it came up on sldev I'll post my views here:

I think that lipsync is a cool feature and it should always be easily accessible from preferences, should be well documented, and people should be made aware of it as a feature. I do not think it should ever be on by default for the same reason bubble chat isn't on by default or if I remember correctly voice chat isn't on by default. It is a nice feature but when it comes down to the essentials of being able to use SL it is unnecessary fluff and people shouldn't have to have it on by default and then have it be on them to have to figure out how to turn it off.

If they want it on then they can easily enough turn it on but for non-essential features people should be able to turn on what they want but not be forced to turn anything off by default.


Mm Alder added a comment - 29/Apr/09 07:25 AM - edited
Gordon, SL is all "unnecessary fluff": idle motions, blinking eyes, swaying trees, day/night cycles, wind noise, avatar customization, object physics, particles, flying, and on and on. Do you believe all of these features should be turned off by default? What do you think are the "essentials" of SL? If the goal is to create a virtual world, and that virtual world includes human avatars, is it essential that it be a world or ventriloquists?

When voice chat is disabled, there is no lip sync. When voice chat is enabled, it seems reasonable to enable lip sync as well, but that is currently an additional setting. How is that useful?


Gordon Wendt added a comment - 29/Apr/09 08:16 AM
I don't think any existing feature should be turned off by default however I think we should think long and hard before we add new features that are on by default. I don't really see why this should be on by default when from everything I've read it seems like it's been useful and been a success being an option to be able to turn on if they wish or keep off if they wish.

Maggie Darwin added a comment - 29/Apr/09 11:35 AM
Um...isn't lipsync an "existing feature"? It's already in the GA viewer.

Not that "all existing features should be turned on by default", or we'll all be walking around with those stupid ARC numbers over our heads.


Torian Carter added a comment - 04/May/09 09:15 AM
As LL's goal is to make the client more accessible to new users (read dumb down), then having more features on by default does not help with the new user experience. It's pretty clear that the new initial interface settings are made so that people with modest computer power have a good experience. If that was not the case then things like 'local lights' and 'advanced shaders' would be on by default. If voice is off by default, what use would lip sync on by default be?
One change I would like to see is 'lip sync on = annoying white dot over head off'

Rob Linden added a comment - 06/May/09 05:37 PM
Per conversation on the mailng list, we'd like to have something in Preferences/Voice before turning this on by default. I've filed this as VWR-13260. Anyone want to take a stab at that one?

Merov Linden added a comment - 19/May/09 02:11 PM
The attached patch is the concatenation of both Mm Alder's in one plus:
  • suppress the old Advanced menu item (now unnecessary)
  • add French localization (as an example of l10n)

Mm Alder, could you review the patch?

Once reviewed, I'll commit the change (note: tested on Windows, works nicely, no UI issue I could notice)

Also, could you write a test plan? Append it in here as a comment (see Aimee's VWR-8008 as an example).

Thanks!


Mm Alder added a comment - 19/May/09 04:49 PM
Merov, you have mixed UNIX and MS Windows line endings on the two XML files and the French one is misaligned on the left margin. Functionally, they look good.

I don't know how Aimee got the formatting on her test plan. I don't know enough about JIRA formatting to do that, but here's the plan:

1. On a clean install, enable voice chat if it's not (I don't know whether it is by default or not).

2. Go to a sim that allows voice chat.

3. Adjust the camera so you can see your avatar's face. You should also see a white dot above your avatar's head. If you don't see the white dot, you're either zoomed in too close, or you don't have voice chat enabled.

4. Key your microphone and say something. You should see green waves above your avatar's head and your avatar's mouth should move. If you don't see the green waves, you didn't key your microphone properly. If you see the green waves, but the mouth didn't move, that's a failure. Even if you fail, go to step 5.

5. Go to Edit->Preferenced->Voice Chat. Nothing in the panel should be greyed out. If it is, then you didn't enable voice chat. Enable it and go back to step 2. If the panel looks fine, then (assuming you're on an English system) you should see a section "Lip Sync Mouth Animation" and under that should be a checkbox labeled "Enable lip sync animation" and it should have a check in it. If not, that's a fail. If the box is there, but not checked, check it, hit OK, and go to step 2 anyway. The last line of the panel above the buttons should read: "Chat, and changes you make will be immediately applied." If not, we tried to jam too much on the panel. That's a fail.

6. Select the checkbox. The check mark should go away. If not, you didn't do it right. We know these widgets never fail.

7. Do steps 2 and 3 again.

8. Key your microphone and say something. You should see green waves above your avatar's head but your avatar's mouth should not move. If you don't see the green waves, you don't have voice enabled or you didn't key your microphone properly. If you see the green waves, and the mouth moved, that's a failure.

9. Repeat step 5 to enable lip sync because it's a really cool feature. You passed.


Merov Linden added a comment - 19/May/09 05:58 PM
Thanks for pointing the indentation and eol issue to me Mm Alder. I committed that to svn rev 2291.

Your test plan look good. Thanks!


Merov Linden added a comment - 19/May/09 05:59 PM
Committed to the snowglobe project (http-texture branch). svn rev 2291.

Mm Alder added a comment - 04/Aug/09 06:51 AM
This patch seems to have no problems in Snowglobe. How about putting it in the official release now?

Gordon Wendt added a comment - 04/Aug/09 10:09 AM
Again I would like to note my continued opposition to this feature being on by default. This is definitely a cool feature but I see no reason why this should be on by default.

Gordon Wendt added a comment - 13/Aug/09 05:11 PM
I'd like to note doubly so after re-reading one of the previous LL comments regarding the most recent patch that it also removes the advanced menu setting for it making it for all intents and purposes impossible to disable. That just isn't right.

Mm Alder added a comment - 14/Aug/09 11:54 AM
Gordon, it removes the advanced menu setting, but adds a setting Edit->Preferences->Voice Chat->Enable lip sync animation

Gordon Wendt added a comment - 14/Aug/09 10:01 PM
Yeah sorry about that,. was quickly reading the changes via email on vacation (unfortunately now over) and totally blanked on it being added to options. Consider my previous comment withdrawn.

Adeon Writer added a comment - 06/Nov/09 03:57 PM - edited
Tofu Linden Wrote:
The existing lipsync doesn't really move the actual jaw attachment point.
(end quote)

And I don't think it should, it would break existing content. If there needs to be an attachment that moves with the mouth it could be a new attachment point.

That said, I'm all for on by default!