• All submissions to this site are governed by Second Life Project Contribution Agreement. By submitting patches and other information using this site, you acknowledge that you have read, understood, and agreed to those terms.
MAINTENANCE ANNOUNCEMENT - JIRA will undergo maintenance starting 1:00am PDT through 3:00am on Saturday 2010.03.20. Please do not enter issues during this time as the system maybe restarted.
Issue Details (XML | Word | Printable)

Key: SNOW-71
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Normal Normal
Assignee: Aimee Trescothick
Reporter: Aimee Trescothick
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
6. Second Life Snowglobe - SNOW

Gesture auto-completion adds uncommitted suggestions to the line editor history

Created: 25/Jun/09 05:20 PM   Updated: 24/Aug/09 05:20 PM
Component/s: Chat/IM, User Interface
Affects Version/s: Snowglobe 1.0
Fix Version/s: Snowglobe 1.1

Time Tracking:
Not Specified

File Attachments: 1. Text File VWR-14278-UncommittedLineHistory.patch (4 kB)
Issue Links:
Relates
 

Patch attached: Patch attached
Linden Lab Internal Branch: snowglobe/trunk - r2462


 Description  « Hide
Typing a gesture trigger in the chat bar adds all the auto-completion suggestions to the line editor history whether they are selected or not.

Repo:

  1. Check that the standard "/excuseme" and "/embarrassed" gestures are active.
  2. Type "/emo" (or anything starting with "/em") into the chat bar and hit enter.
  3. Press Ctrl-Up Arrow several times to examine the line history.

The line history should only contain "/emo" as that was what was sent, it actually now contains:

  • /emo
  • /embarrassed
  • /excuseme
  • (A blank line)

At present the setText method of the line editor adds entries to the line history, when only committed lines should be being added. The attached patch consolidates the line history code so that the history is only altered by the updateHistory method alone.

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
[ Permlink | « Hide ]
Rob Linden added a comment - 27/Jun/09 10:35 AM
This patch looks a little more complicated than I'm capable of doing a knowledgeable review of. However, I buy the logic, and I think the best course of action is to get this committed now so that I can kick off another build and we can solicit some targeted black box testing for this. So, go ahead and check this in. Thanks!

[ Permlink | « Hide ]
Aimee Trescothick added a comment - 27/Jun/09 03:53 PM
OK, makes sense, it's now commited.

[ Permlink | « Hide ]
Rob Linden added a comment - 02/Jul/09 10:24 AM
Per Aimee, fix available in 1.1.0.2462


Powered by Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.2-#335) - Bug/feature request - Atlassian news - Contact Administrators