|
|
|
Actually, pressing the video widget button does re-enable streaming audio. yayy!
I am not sure if just trying to play a video is enough to do the trick: there seem to be other conditions which have to be met before audio comes on. The audio stutters a lot and the computer runs really slowly after audio fires back up.' Voice behaves the same way after the audio returns: i.e., it acts normal except it doesn't hear the microphone. Yes, the audio widget is messed up post
Good news: it's the same problem with the most recent internal LL branch so it's not a merge issue I did. Bad news: we still have to figure out a fix in Snowglobe :/ Funny: I looked at the code in lloverlaybar and llmediaremotectrl and I see why it doesn't work... Actually, I wonder how it ever worked at that point... I've seen in the past inconsistent display for those buttons myself and I never understood the difference between pause and stop (in the code, there's none...). I'm willing to rewrite this a minima (i.e. without rearchitecturing the whole darn thing, just make it work). I'd appreciate though if people would point me to other known reported bug related to this UI.
Yeah, streaming audio 'broke' for me the minute the media API stuff was added. Controls were ghosted out in all builds from 2826 to 2850, further testing revealed that it could be un-ghosted through a combination of playing with preferences (toggling audio on/off), and using the play media button as a master control. That is, in some instances if you hit play media, the streaming audio controls would become un-ghosted, allowing you to play the parcel's streaming media. Though after hitting play, if you hit stop on the media controls, the audio controls would re-ghost.
However streaming audio has been working for me again in 1.2.0 build 2850 (Mac version). Broken again with 2863. Dropping back down to 2850, and streaming doesn't appear to be working properly there anymore either. Quitting and dropping AGAIN, this time back down to 2826, and hoping somebody QC's streaming audio next time. Broken streaming audio is a showstopper, IMHO it's not worth building/publishing unless that works.
Patch attached. The gist: the old code had a bug that disabled "media" instead of "music" if the mime-type was nill or none/none. This was "fixed" blindly but not tested. The problem is that the mime-type is updated very late (10 seconds or more) after the stream starts so, in effect, testing the mime-type does not work. The patch just suppress that test. It seems that simply testing the existence of the gAudiop instance is enough.
Requesting review from sldev contributors. Looks good to me, and the play button now works... However, I'm still not getting playback because of
Nitpicking the comment though, enabling the button now depends on gAudiop AND the music url not being empty... Thanks for the code review Thickbrick. I think
Will be committing the attached patch immediately. Revision 2866
 by merov.linden on 2009-10-08 13:50:41 -0500 (Thu, 08 Oct 2009)
Files affected: @Merov: The thing is, on Linux fmod isn't being used anymore, instead gstreamer is used for both Parcel Media (movies AND audio) and Parcel Music (audio only), AFAIK.
Hmm, BTW, I just looked, and libfmod-3.75.so IS being packaged in the binaries from LL for both Snowglobe and 1.23, but I think it's not doing anything in either. Linux users would notice if it were, since fmod on Linux uses OSS sound by default, which tends to hog the sound card, preventing anything else from playing audio. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 |
|
Sub-task
Resolved
Major
SNOW-222merge, in that to play the audio stream you have to first play media to enable the audio play button, does it work at all if you do that? I was hoping to fix it before the merge but didn't get there in time.Ambient sound isn't normally played using Quicktime anyway, so that will still work without it.