[#SNOW-257] New translation pref in "Local Chat" floater makes minimum window width too large

6. Second Life Snowglobe - SNOW

SNOW-93

New translation pref in "Local Chat" floater makes minimum window width too large

Created: 29/Sep/09 02:10 PM Updated: 02/Oct/09 10:53 AM

Return to search

Component/s:

Chat/IM

Affects Version/s:

Snowglobe 1.2

Fix Version/s:

Snowglobe 1.2

File Attachments:

floater_chat_history.xml (6 kB)
2.

SNOW-257.patch (3 kB)

Image Attachments:

1. verticalpref.png
(24 kB)

Issue Links:

Duplicate

This issue is original of duplicate:

~~SNOW-258~~ chat window is not sizable horizontally 1.2 Build 2804

Relates

This issue Relates to:

~~SNOW-253~~ Put translation pref in "Local Chat" floater

Description

« Hide

The implementation of the translation pref in the "Local Chat" floater (~~SNOW-253~~) makes the minimum window width wider than it probably should be. The reason for this is to avoid a situation where the preference completely disappears due to floater resizing.

Possible fixes:
1. Putting the translation preference underneath the "Show Muted Text" preference
2. Changing the minimum back to the old minimum, and allowing the prefs to disappear
3. Leave it as it is checked in
4. Something else?

All

Comments

Change History

Sort Order:

[ Permlink | « Hide ]

Aimee Trescothick added a comment - 29/Sep/09 03:26 PM

Speaking as someone that has the local chat window open pretty much all the time, as I know many other people do while multi-tasking, this needs fixing before we release 1.2. This change makes the minimum width of the local chat floater over half the width of my Second Life window at the size I often have it, causing it to obscure most of my view.

I would also say the text label is too verbose, just make it "Translate chat" and place the more verbose version in a tooltip.

[ Permlink | « Hide ]

Rob Linden added a comment - 29/Sep/09 04:03 PM

On the problem of label verbosity, we'll probably need to keep it longer than folks might like (we have to include the "powered by Google" bit)

I'm going to play around with putting it underneath "Show Muted Text". It'll make the dialog a little taller, but not by much, and I think it'll be worth the tradeoff.

[ Permlink | « Hide ]

Aimee Trescothick added a comment - 29/Sep/09 05:52 PM

I'm not sure of Google's requirements, but I shouldn't think it has to display "powered by Google" when it's off (i.e. not being powered by Google

)

Could we not do something like just putting a powered by Google tag over the top right corner of the chat history area when it's switched on? Requiring attribution is fair enough, but when I'm not using their API I shouldn't have to look at their branding, although I guess they could argue that the fact it's included and available makes it brandable.

[ Permlink | « Hide ]

Rob Linden added a comment - 29/Sep/09 11:56 PM

I'm not sure of Google's requirements, but I shouldn't think it has to display "powered by Google" when it's off (i.e. not being powered by Google

True. Patches welcome

Anyway, attached is a patch that implements the vertical stacking idea (#1) and makes it a little less verbose. I've also attahced the full file for the sake of convenience for people that just want to do a runtime replacement.

Lemme know if this version is better...if so, I'll check it in.

[ Permlink | « Hide ]

Rob Linden added a comment - 30/Sep/09 04:25 PM

Planning to commit here in a sec. Attached is a screenshot of the new pref in action

[ Permlink | « Hide ]

lindenrobot added a comment - 30/Sep/09 04:27 PM

Revision 2810 by rob.linden on 2009-09-30 18:27:25 -0500 (Wed, 30 Sep 2009)

~~SNOW-257~~ - New translation pref in "Local Chat" floater makes minimum window width too large. Reviewed by AimeeT

Files affected:
U projects/2009/snowglobe/trunk/indra/newview/skins/default/xui/en-us/floater_chat_history.xml

[ Permlink | « Hide ]

Rob Linden added a comment - 02/Oct/09 10:53 AM

Done