[#SNOW-253] Put translation pref in "Local Chat" floater

6. Second Life Snowglobe - SNOW

SNOW-93

Put translation pref in "Local Chat" floater

Created: 27/Sep/09 11:17 PM Updated: 29/Sep/09 02:14 PM

Return to search

Component/s:

Chat/IM

Affects Version/s:

None

Fix Version/s:

Snowglobe 1.2

File Attachments:

translate-chat.patch (5 kB)

Image Attachments:

1. translatepref.png
(71 kB)

Issue Links:

Relates

This issue is related to by:

~~SNOW-257~~ New translation pref in "Local Chat" floater makes minimum window width too large

Description

« Hide

Currently, the preference for translating chat is buried in the the prefs dialog along with a gazillion other preferences. The attached patch puts the preference right at the top of the "Local Chat" window.

TODO:

Add other languages besides en-us
Reposition the text, so that it doesn't look so floaty

All

Comments

Change History

Sort Order:

[ Permlink | « Hide ]

Rob Linden added a comment - 28/Sep/09 11:55 AM

I did some playing around today, and it appears as though the best thing to do is to leave things pretty much as I have until someone who actually knows the language does a translation. I've updated the text for a little more clarity and using the Google-recommended wording for the "powered by Google" bit.

[ Permlink | « Hide ]

Ramzi Linden added a comment - 28/Sep/09 02:50 PM

On the proposed patch:

Without some further change in floater_chat_history.xml, the new checkbox is easily clipped/vanished awkwardly by a resizing the Local Chat window.

To repro, shrink the Local Chat window horizontally, then open the (<<) Participant List.

The value that would need to be changed further is the min_width of the parent <floater> node:

<floater bottom="27" can_close="true" can_drag_on_left="false" can_minimize="false"
     can_resize="true" can_tear_off="true" enabled="true" height="270" left="15"
     min_height="150" min_width="425" mouse_opaque="true" name="chat floater"
     rect_control="FloaterChatRect" title="Local Chat" width="435">

The min_width might need to increase by 200px in order to prevent the floater from shrinking smaller than the text labels it contains. Or perhaps more, because opening the (<<) Participants panel in this floater further truncates the new checkbox.

In localizations, we typically increase the enforced min_width to prevent this kind of awkward "disappearing UI." It is a workaround to inherent I18N design limitations in the floater's layout of widgets.

[ Permlink | « Hide ]

Thickbrick Sleaford added a comment - 28/Sep/09 05:52 PM

I reviewed this and tested... looks good to me (except for the width issues above...)

[ Permlink | « Hide ]

Rob Linden added a comment - 29/Sep/09 12:13 PM

Hi Ramzi and Thickbrick - thanks for the review. I'm worried that enforcing a larger minimum width might annoy people more than having the text truncated at minimum width, but now that I've opened the Participant List, I can see how this would completely disappear. Hrmph.

Ok, here's what I'm going to do. I'm going to increase the minimum width for now. However, I'm also going to file a bug to make sure we don't leave it like that, because I think that'd suck. More in a bit....

[ Permlink | « Hide ]

lindenrobot added a comment - 29/Sep/09 12:26 PM

Revision 2804 by rob.linden on 2009-09-29 14:26:03 -0500 (Tue, 29 Sep 2009)

~~SNOW-253~~ - Put translation pref in "Local Chat" floater

Files affected:
U projects/2009/snowglobe/trunk/indra/newview/llfloaterchat.cpp
U projects/2009/snowglobe/trunk/indra/newview/llfloaterchat.h
U projects/2009/snowglobe/trunk/indra/newview/llviewercontrol.cpp
U projects/2009/snowglobe/trunk/indra/newview/skins/default/xui/en-us/floater_chat_history.xml

[ Permlink | « Hide ]

Ramzi Linden added a comment - 29/Sep/09 12:33 PM

A more I18N-friendly layout might be to put the checkbox underneath the existing one, [X] Show muted text. (like a vertical list). However that also needs (some) re-layout of the XUI to make it work.

Either way is possible... These are the joys and angst of the viewer's UI design.

[ Permlink | « Hide ]

Rob Linden added a comment - 29/Sep/09 02:12 PM

Thanks for the suggestion Ramzi. I've created ~~SNOW-257~~ as a reminder to address this problem (or decide not to address the problem, as the case may be).