[#SNOW-247] Chat bubbles show "...", but don't show the actual text of the message.

6. Second Life Snowglobe - SNOW

SNOW-93

Chat bubbles show "...", but don't show the actual text of the message.

Created: 24/Sep/09 02:17 PM Updated: 01/Oct/09 10:07 AM

Return to search

Component/s:

Chat/IM

Affects Version/s:

Snowglobe 1.2

Fix Version/s:

Snowglobe 1.2

File Attachments:	1. SNOW-247_translation_breaks_chat_bubbles.diff (4 kB)
Environment:	Snowglobe 1.2.0 (2785) Sep 23 2009 19:32:03 (Snowglobe Test Build)

Patch attached:

Patch attached

Description

« Hide

This is a subtask of ~~SNOW-93~~

After the ~~SNOW-93~~ patch, chat bubbles show animated "..." when typing, but after sending the chat message, the chat bubble becomes blank immediatly, never showing the message.

This happens whether chat translation is on or off.

All

Comments

Change History

Sort Order:

[ Permlink | « Hide ]

Thickbrick Sleaford added a comment - 27/Sep/09 10:27 AM - edited

Here is a patch that fixes this. It does 2 things:

In llviewermessage.cpp: Revert process_chat_from_simulator() to be more like the old behavior - fill chat.mText with the message (so it shows up in the bubbles). ~~SNOW-93~~ moved filling chat.mText with the original message to check_translate_chat(), but I don't see a reason for it.
In lltranslate.h: remove protected member m_mesg from TranslationReciever. It was only being used in the lines removed from llviewermessage.cpp. I see no reason for m_mesg to exist, except for filling chat.mText later, and that serves no purpose either. Maybe the intent was to allow comparing the translated text to the original message (and discard if identical) in the future?

Note: this doesn't add the translated text to the chat bubbles, it just makes them not blank. With chat bubbles enabled, the translation is only visible in the local chat window.

Test plan
Set the translation language to non-english, and repeat the following with all combinations of chat bubbles on and off, translation on and off:

Say in local chat: "testing"
Say in local chat: "/me is testing"
Verify:
1. Correct text appears in local chat and local chat window (including translation, when activated.)
2. Correct text appears in chat bubbles (without translation)

[ Permlink | « Hide ]

Opensource Obscure added a comment - 28/Sep/09 06:50 AM

This will be very appreciated! I usually don't enable chat bubbles but I have some friends that use translation and are on Snowglobe and they are afflicted by this bug.

I plan to try this patch in the next hours and give some feedback.
(can anyone remind me which sources tree must I apply the against?)

[ Permlink | « Hide ]

Thickbrick Sleaford added a comment - 28/Sep/09 07:05 AM

This is against Snowglobe trunk, i.e.
http://svn.secondlife.com/svn/linden/projects/2009/snowglobe/trunk/

[ Permlink | « Hide ]

Opensource Obscure added a comment - 28/Sep/09 11:19 AM

Patch works as detailed above (applied against revision 2795).

Snowglobe 1.2.0 (0) Sep 28 2009 18:54:28 (CommunityDeveloper)
Built with GCC version 40303
CPU: Intel(R) Core(TM)2 CPU 6420 @ 2.13GHz
Memory: 4025 MB
OS Version: Linux 2.6.28-11-server #42-Ubuntu SMP Fri Apr 17 02:48:10 UTC 2009 i686
Graphics Card Vendor: NVIDIA Corporation
Graphics Card: GeForce 9600 GT/PCI/SSE2
OpenGL Version: 3.0.0 NVIDIA 180.44
libcurl Version: libcurl/7.16.4 OpenSSL/0.9.7c zlib/1.2.3.3 c-ares/1.4.0
J2C Decoder Version: OpenJPEG: 1.3.0, Runtime: 1.3.0
Audio Driver Version: OpenAL, version 1.1 / OpenAL Community / OpenAL Soft: ALSA Software on default
LLMozLib Version: [LLMediaImplLLMozLib] - 2.01.27188 (Mozilla GRE version 1.8.1.18_0000000000)

[ Permlink | « Hide ]

Ardy Lay added a comment - 29/Sep/09 06:34 PM

This patch seems to correct the described issue for me too.

[ Permlink | « Hide ]

lindenrobot added a comment - 30/Sep/09 05:40 PM

Revision 2813 by rob.linden on 2009-09-30 19:40:17 -0500 (Wed, 30 Sep 2009)

~~SNOW-247~~ - Chat bubbles show "...", but don't show the actual text of the message. Contributed by Thickbrick.

Files affected:
U projects/2009/snowglobe/trunk/doc/contributions.txt
U projects/2009/snowglobe/trunk/indra/newview/lltranslate.h
U projects/2009/snowglobe/trunk/indra/newview/llviewermessage.cpp

[ Permlink | « Hide ]

Rob Linden added a comment - 01/Oct/09 10:07 AM

Checked in